linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Fix crash that occurs when function tracing is enabled

To: Al Cooper <alcooperx@gmail.com>
Subject: Re: [PATCH] MIPS: Fix crash that occurs when function tracing is enabled
From: David Daney <ddaney.cavm@gmail.com>
Date: Thu, 15 Nov 2012 15:30:54 -0800
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, cernekee@gmail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=RRPTCLcOzB0Poqu+fY7wx2jkqybJHJbZ5uNMDmFVCts=; b=IF+kdP7GuwQFxnQj8y5pdq5hCtdC2wS4+cGYEOQ3cLURZ0m4I0tjgvh5XgjkCjNEkm cLvBDITH0JUVMUb0xreFRveaXldqPhiJSjkmdOrU1KCa+MeZD9MWbY/N7OxLVLVUnr1L fpPPlvFbhUfpCnzkZCKwcOdpoBfy6gc7VVXSGTGRGCEj5y5T71ztB6ovV9mc80yen/xb 6wwNrx+Ic2n2HNxlO6FdYJCDLMY9VVhm4OkYpzJEeP8wEbuwlbH6tlD5/7+VmiVlJ7Oc /KpVWwfVg91m4OgqxR6QzEM+TqNa2GAANRsytO/P2U4A+s9plPLsqrSzrhQPEA7O4kb8 s1Yw==
In-reply-to: <1353021374-3311-1-git-send-email-alcooperx@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <y> <1353021374-3311-1-git-send-email-alcooperx@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2
On 11/15/2012 03:16 PM, Al Cooper wrote:
A recent patch changed some irq routines from inlines to functions.
These routines are called by the tracer code. Now that they're functions,
if they are compiled for function tracing they will call the tracer
and crash the system due to infinite recursion. The fix disables
tracing in these functions by using "notrace" in the function
definition.

Signed-off-by: Al Cooper <alcooperx@gmail.com>

Makes sense,

Reviewed-by: David Daney <david.daney@cavium.com>


---
  arch/mips/lib/mips-atomic.c |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/mips/lib/mips-atomic.c b/arch/mips/lib/mips-atomic.c
index e091430..cd160be 100644
--- a/arch/mips/lib/mips-atomic.c
+++ b/arch/mips/lib/mips-atomic.c
@@ -56,7 +56,7 @@ __asm__(
        "  .set    pop                                             \n"
        "  .endm                                                   \n");

-void arch_local_irq_disable(void)
+notrace void arch_local_irq_disable(void)
  {
.
.
.



<Prev in Thread] Current Thread [Next in Thread>