[Top] [All Lists]

Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree

To: Stephen Warren <>
Subject: Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree
From: Jonas Gorski <>
Date: Wed, 14 Nov 2012 13:13:44 +0100
Cc:, Ralf Baechle <>, John Crispin <>, Maxime Bizon <>, Florian Fainelli <>, Kevin Cernekee <>,,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=yM97CpowIwU6VOs1KvM/kmWIv8Eb1fNGPPpJl9D7ZCU=; b=xgUCaixJ7p6rUos+JBmiBLoG/Yzb+NBNdHJPNHsz7vA3OANX5ia/VqMQxkSlfATlxG CRL+zlnSPk85nfFLYmpiFrdT15CWuLrVhYNNqFeD87YUmWLuCF0ygGrGnIhzKJorX9PA nwWDHko4181tRCjxcF7e+iLcb9Dl6mAMPMHzfUy7trHRQ9U+4uajPCnKvl6d4oEQQZxg sgZm4UIMUQUnjYVp1xfO2zTyG9uSeATFIIlhedtalhF5WSXEiDJMRPP/2gCHRFu+EXkC JxtzEPGP5/T7XWgf3cORWq1LWI1LSDI//0Y8l0AcA078/1vxihDh1nqFx76tvsB3kqNe pnQQ==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <>
On 13 November 2012 06:06, Stephen Warren <> wrote:
> On 11/11/2012 05:50 AM, Jonas Gorski wrote:
>> Register the GPIO controller through Device Tree and add the
>> appropriate values in the include files.
>> Since we can't register a platform driver at this early stage move the
>> direct call to bcm63xx_gpio_init from prom_init to an arch initcall.
>> diff --git a/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt 
>> b/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt
>> +- #gpio-cells: Must be <2>. The first cell is the GPIO pin, and
>> +  the second one the standard linux flags.
> Also here, I think you want to explicitly document the flag values here
> so the bindings don't rely on the Linux kernel code. I don't think
> there's a standard central file which documents them though, although I
> vaguely recall some discussion to create add them to gpio.txt?

I'll add some more description. And yes there isn't, and I can't
comment about that since I just joined devicetree-discuss a few days
ago. It would be nice to have them there. Maybe I'll add a reference
to gpio.txt and see if I can come up with an acceptable description
for the flags.


<Prev in Thread] Current Thread [Next in Thread>