linux-mips
[Top] [All Lists]

Re: [RFC] MIPS: BCM63XX: switch to common clock and Device Tree

To: Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [RFC] MIPS: BCM63XX: switch to common clock and Device Tree
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Wed, 14 Nov 2012 13:12:20 +0100
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Florian Fainelli <florian@openwrt.org>, Kevin Cernekee <cernekee@gmail.com>, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=W1w04TJtqkpx9DpCckt/99u7qOmaHFVSAgI9TccGNwE=; b=pb9gT3n/ISWvm1sLmTdD/uUteZCmXJcSKaMBwwz9dk1+uQtmav+ABHrS2pxnqzxe27 qYltTCyWaJA8c1fC1Rgrm7zrUUpjgz7TZjXI1Kt0E6Ds/9EKPofbwsER8mT8ERXuHb3N eF+Ocg9CX5kucHgqV7av+U9JMsbYIe/N5vTGiK9BCQw+84UFp7aj5bDSEK94tXHDBxNt 1GZIuKmYei6cd1Olntll2TdVDaxwCYUOdiSiVkp0+15C2RbZq2sWfX9Kt8apy4BhmKRg l51QsYlPIU0ruSSnQ+xUYYxV38U+JbU6wZSXGVkf5trqCr5F60Zq65qFc1/Qcm/qp75i +YHw==
In-reply-to: <50A1D4E4.50308@wwwdotorg.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1352638249-29298-1-git-send-email-jonas.gorski@gmail.com> <1352638249-29298-11-git-send-email-jonas.gorski@gmail.com> <50A1D4E4.50308@wwwdotorg.org>
Sender: linux-mips-bounce@linux-mips.org
On 13 November 2012 06:04, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 11/11/2012 05:50 AM, Jonas Gorski wrote:
>> Switch BCM63XX to the common clock framework and use clkdev for
>> providing clock name lookups for non-DT devices.
>>
>> Clocks can have a frequency and gate-bit, or none, in case they
>> are just provided for drivers expecting them to be present.
>
>> diff --git a/Documentation/devicetree/bindings/clock/bcm63xx-clock.txt 
>> b/Documentation/devicetree/bindings/clock/bcm63xx-clock.txt
>
> A very minor nit, but it might be nice to add the DT binding
> documentation before (or as part of) the patches that use them (code
> that parses them, or using the bindings in .dts files)
>
> Of course, I'm relying on my email receive order, to judge this since
> the patch numbering didn't come through, so perhaps the patches are
> already set up this way...

No you are right, the bindings are being added earlier. I move it to
the patch adding the (then still unused) binding to the dts(i) files.
I'd rather not split it up completely, and add it with the binding
usage together so it's easier to spot if I do something with the
bindings that contradicts the documentation or is missing ;-).


Jonas

<Prev in Thread] Current Thread [Next in Thread>