[Top] [All Lists]

Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree

To: Jonas Gorski <>
Subject: Re: [RFC] MIPS: BCM63XX: register GPIO controller through Device Tree
From: Stephen Warren <>
Date: Mon, 12 Nov 2012 22:06:22 -0700
Cc:, Ralf Baechle <>, John Crispin <>, Maxime Bizon <>, Florian Fainelli <>, Kevin Cernekee <>,,
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0
On 11/11/2012 05:50 AM, Jonas Gorski wrote:
> Register the GPIO controller through Device Tree and add the
> appropriate values in the include files.
> Since we can't register a platform driver at this early stage move the
> direct call to bcm63xx_gpio_init from prom_init to an arch initcall.

> diff --git a/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt 
> b/Documentation/devicetree/bindings/gpio/bcm63xx-gpio.txt

> +- #gpio-cells: Must be <2>. The first cell is the GPIO pin, and
> +  the second one the standard linux flags.

Also here, I think you want to explicitly document the flag values here
so the bindings don't rely on the Linux kernel code. I don't think
there's a standard central file which documents them though, although I
vaguely recall some discussion to create add them to gpio.txt?

<Prev in Thread] Current Thread [Next in Thread>