linux-mips
[Top] [All Lists]

Re: [PATCH 15/16] mm: use vm_unmapped_area() on sparc32 architecture

To: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 15/16] mm: use vm_unmapped_area() on sparc32 architecture
From: Michel Lespinasse <walken@google.com>
Date: Mon, 5 Nov 2012 19:13:19 -0800
Cc: akpm@linux-foundation.org, riel@redhat.com, hughd@google.com, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, ralf@linux-mips.org, lethal@linux-sh.org, cmetcalf@tilera.com, x86@kernel.org, wli@holomorphy.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=b6ZGmbY7E4bhjKbD7Z8i73TS0+PLbwPmh288yLt0ESc=; b=Ng0lLBAISCS71s4PWjo0JB8VBNCnArfqi31INKPywnPPsVu0eh1Jef0oWvz6tOjIJj o1pJx3aZ8IG96X6VQSSqv4H2n/yk/JlGyrRN9KbkdeTcn/EP8EzL31Gt3Py2mEg9sQG/ gbEQMe9ZrpqpTX5by/UAe8OqjYfe8Gn+jleN19C8tGJdCVng4YfADg/wZnxNI/cMegj4 v1+FTDtkX+Ohnn7zwnGvSriOHfb1NQ5rpc3G2PaUw0r/bCWwU5WVImZhwqryVtOc4tlp UNukhBfuMFuZ75aDFJOlFsUKVsMlH3NUDYn461BxxngZHZBxBHu2mF3aUcZFlSpPnHq5 vqLQ==
In-reply-to: <20121105.202501.1246122770431623794.davem@davemloft.net>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1352155633-8648-1-git-send-email-walken@google.com> <1352155633-8648-16-git-send-email-walken@google.com> <20121105.202501.1246122770431623794.davem@davemloft.net>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Nov 5, 2012 at 5:25 PM, David Miller <davem@davemloft.net> wrote:
> From: Michel Lespinasse <walken@google.com>
> Date: Mon,  5 Nov 2012 14:47:12 -0800
>
>> Update the sparc32 arch_get_unmapped_area function to make use of
>> vm_unmapped_area() instead of implementing a brute force search.
>>
>> Signed-off-by: Michel Lespinasse <walken@google.com>
>
> Hmmm...
>
>> -     if (flags & MAP_SHARED)
>> -             addr = COLOUR_ALIGN(addr);
>> -     else
>> -             addr = PAGE_ALIGN(addr);
>
> What part of vm_unmapped_area() is going to duplicate this special
> aligning logic we need on sparc?

The idea there is that you can specify the desired alignment mask and
offset using info.align_mask and info.align_offset.

Now, I just noticed that the old code actually always uses an
alignment offset of 0 instead of basing it on pgoff. I'm not sure why
that is, but it looks like this may be an issue ?

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

<Prev in Thread] Current Thread [Next in Thread>