linux-mips
[Top] [All Lists]

Re: [PATCH 12/20] KVM/MIPS32: Routines to handle specific traps/exceptio

To: Sanjay Lal <sanjayl@kymasys.com>
Subject: Re: [PATCH 12/20] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest.
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 31 Oct 2012 11:16:27 -0700
Cc: kvm@vger.kernel.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sNWWWo5j/3xoxGXpVGa0Vm9Mc/F6CSlF1Zz8utIWrdI=; b=YMw2Pezxb6QqEBtaESRtifsaVCZIDlvlXRlWoCIRkJqhoCLfSFRTZx81sB771w6RF/ LuCB2N3bGwfnW4siTaSb0Dav9oHa4rR40y/W0RWY93M5eM1ny18jf/z7X/iUmY4KzUg1 vgNookMb7VPVbc3OAMAlIzNUiDk9S/5MlKR4LKDAb4FwBCqlHdM/NqNskpQxYSFyqvu3 H7DwruIisDrAQQevA7nJJYNT31yuFqS+/AKIZy5VgxvWv7RGxSvGozNxrZDmhFMVnSlq f+EZw8FDB9NQPdzFSiBMwUb1CBfiDav/ryKs7DbhzdpsHsOG2hAXizXn1xjRSc7NTOki KF8Q==
In-reply-to: <DD56E216-2017-45D0-9623-62E27F56CA58@kymasys.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <DD56E216-2017-45D0-9623-62E27F56CA58@kymasys.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1
On 10/31/2012 08:20 AM, Sanjay Lal wrote:
Signed-off-by: Sanjay Lal <sanjayl@kymasys.com>
---
  arch/mips/kvm/kvm_cb.c        |  16 ++
  arch/mips/kvm/kvm_trap_emul.c | 446 ++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 462 insertions(+)
  create mode 100644 arch/mips/kvm/kvm_cb.c
  create mode 100644 arch/mips/kvm/kvm_trap_emul.c


At a minimum you should probably follow Documentation/CodingStyle

Running checkpatch.pl on all the patches and fixing obvious problems is always a good idea.


diff --git a/arch/mips/kvm/kvm_cb.c b/arch/mips/kvm/kvm_cb.c
new file mode 100644
index 0000000..768198e
--- /dev/null
+++ b/arch/mips/kvm/kvm_cb.c
@@ -0,0 +1,16 @@
+/*
+* This file is subject to the terms and conditions of the GNU General Public
+* License.  See the file "COPYING" in the main directory of this archive
+* for more details.
+*
+* PUT YOUR TITLE AND/OR INFORMATION FOR THE FILE HERE

That line can probably be safely removed.


+*
+* Copyright (C) 2012  MIPS Technologies, Inc.  All rights reserved.
+* Authors: Yann Le Du <ledu@kymasys.com>
+*/
.
.
.

David Daney

<Prev in Thread] Current Thread [Next in Thread>