linux-mips
[Top] [All Lists]

Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_m

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error
From: Shuah Khan <shuah.khan@hp.com>
Date: Tue, 30 Oct 2012 13:58:46 -0600
Cc: ralf@linux-mips.org, kyungmin.park@samsung.com, arnd@arndb.de, andrzej.p@samsung.com, m.szyprowski@samsung.com, linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>, shuahkhan@gmail.com
In-reply-to: <508B0F4B.80601@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: ISS-Linux
References: <1351208193.6851.17.camel@lorien2> <1351267298.4013.12.camel@lorien2> <508ABE1D.5010106@gmail.com> <1351271198.4013.35.camel@lorien2> <508AED66.3040808@gmail.com> <1351288264.6885.11.camel@lorien2> <508B0F4B.80601@gmail.com>
Reply-to: shuah.khan@hp.com
Sender: linux-mips-bounce@linux-mips.org
On Fri, 2012-10-26 at 15:31 -0700, David Daney wrote:
> On 10/26/2012 02:51 PM, Shuah Khan wrote:
> 
> >>>> On 10/26/2012 09:01 AM, Shuah Khan wrote:
> >>>>> Add support for debug_dma_mapping_error() call to avoid warning from
> >>>>> debug_dma_unmap() interface when it checks for mapping error checked
> >>>>> status. Without this patch, device driver failed to check map error
> >>>>> warning is generated.
> 
> I'm confused.
> 
> Your claim that a 'warning is generated' seems to be in conflict with...
> 
> 
> [...]
> > Got it. Thanks. I would volunteer to look at fixing all the problems,
> > but unfortunately I don't have a MIPS box handy
> 
> This statement that you don't have hardware that exhibits the problem.
> 
> How was the patch tested?  How do you even know there is a problem?

I enhanced the existing dma debug interfaces to add an interface to
debug missing dma_mapping_error() checks. That went into linux-next.
With this patch, when dma_map_page() and dma_map_single() are debugged
with a call to debug_dma_map_page() and the corresponding
dma_mapping_error() interface doesn't call debug_dma_mapping_error()
interface, a warning will be generated. I have been sending changes to
arch specific dma_mapping_error() routines to add this debug interface.
That is why I marked this patch RFT requesting testing.

Thanks,
-- Shuah



<Prev in Thread] Current Thread [Next in Thread>