linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BC

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BCM6358
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 29 Oct 2012 12:10:49 +0100
Cc: Jonas Gorski <jonas.gorski@gmail.com>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Kevin Cernekee <cernekee@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=6p5g2lE88LttlyRrHddxmCPm8xrf4NInDWwpXDau2bw=; b=ujxyr8CypMpVEnoLkVs2aW6vauqf7T+U2vG2n0Z55eJFq0jAYFTPW6SnqSpv3tfZD3 v9LgIixuws6wNoKP5YUr2YCXb3/zGhSRWCb/Tfx2F7yHkkAlEnhVZ+9YJNay0vSxPRxL AImtvKZM4XqDILXMKyVhdTdIIeXIW2zan66g1V1cCmPyTt8/ea5lk1e9MMQfPlUAK/vS IbGTF2mnsgV2OXt1IbF/iup/cQzdXVm8NY+cUx/+4+Pv78o60TpNXOzoEKWZoOyrbTyi A4Baw7GyHAJjnD+0seEzPtcrdJxOdhYLe2fRHvZ5lyFRgCe1IYNInAmd0PTFiEp3/XLO UVPg==
In-reply-to: <508E60DB.6050005@mvista.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1351430275-14509-1-git-send-email-jonas.gorski@gmail.com> <1351430275-14509-2-git-send-email-jonas.gorski@gmail.com> <508E60DB.6050005@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.9.2 (Linux/3.5.0-17-generic; KDE/4.9.2; x86_64; ; )
On Monday 29 October 2012 14:56:27 Sergei Shtylyov wrote:
> Hello.
> 
> On 28-10-2012 17:17, Jonas Gorski wrote:
> 
> > The softreset register description for BCM6358 was missing, so add it.
> 
> > Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> > ---
> >   arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h |   10 ++++++++++
> >   1 files changed, 10 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h 
> > b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> > index 12963d0..e84e602 100644
> > --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> > +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> [...]
> > @@ -244,6 +245,15 @@
> >                               SOFTRESET_6348_ACLC_MASK |            \
> >                               SOFTRESET_6348_ADSLMIPSPLL_MASK)
> >
> > +#define SOFTRESET_6358_SPI_MASK            (1 << 0)
> > +#define SOFTRESET_6358_ENET_MASK   (1 << 2)
> > +#define SOFTRESET_6358_MPI_MASK            (1 << 3)
> > +#define SOFTRESET_6358_EPHY_MASK   (1 << 6)
> > +#define SOFTRESET_6358_SAR_MASK            (1 << 7)
> > +#define SOFTRESET_6358_USBH_MASK   (1 << 12)
> > +#define SOFTRESET_6358_PCM_MASK            (1 << 13)
> > +#define SOFTRESET_6358_ADSL_MASK   (1 << 14)
> > +
> 
>     Why not use BIT(n) instead of (1 << n)?

All other bcm63xx headers consistently use (1 << n), I would rather we keep
this convention.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>