linux-mips
[Top] [All Lists]

Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_m

To: shuah.khan@hp.com
Subject: Re: [PATCH RFT RESEND linux-next] mips: dma-mapping: support debug_dma_mapping_error
From: David Daney <ddaney.cavm@gmail.com>
Date: Fri, 26 Oct 2012 09:45:17 -0700
Cc: ralf@linux-mips.org, kyungmin.park@samsung.com, arnd@arndb.de, andrzej.p@samsung.com, m.szyprowski@samsung.com, linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>, shuahkhan@gmail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=8i8hVYcUX+rwHIFnyWLD94epR5+UVt0OL1fvi52rhg8=; b=AogWKKRj86ZZZzAgeCNGXWVv1LV38OjWhEqZnIjX9Rc8TXKd6ZO9hUiym6YhKs7ZXl iB2VMZ8e+sFiFQh7yB8PYpGNwYDge5uq2x9ClxqaI6pFFq/MEgb0CI94727E6lRA6PeM juPh5UsJAEOOyvGhzJOsVCY9fEHIrgSGcxb3xDfyZdV1gIBW2FsTXN5piy0qMbCfQqMC N7uVBcMx+paijq8fCmko3oiQnesA+M3J7kZfHe7KHpdV+CgAZwR8RCl+prnWMHOglm6d YpavKLCFl/LsHTkcnz7Kfdj733i9j+iY35zEpLYb0kbVDk9OyHursOxDwJLdgNM7eVfI mZcg==
In-reply-to: <1351267298.4013.12.camel@lorien2>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1351208193.6851.17.camel@lorien2> <1351267298.4013.12.camel@lorien2>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1
On 10/26/2012 09:01 AM, Shuah Khan wrote:
Add support for debug_dma_mapping_error() call to avoid warning from
debug_dma_unmap() interface when it checks for mapping error checked
status. Without this patch, device driver failed to check map error
warning is generated.

Signed-off-by: Shuah Khan <shuah.khan@hp.com>
---
  arch/mips/include/asm/dma-mapping.h |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/mips/include/asm/dma-mapping.h 
b/arch/mips/include/asm/dma-mapping.h
index be39a12..006b43e 100644
--- a/arch/mips/include/asm/dma-mapping.h
+++ b/arch/mips/include/asm/dma-mapping.h
@@ -40,6 +40,8 @@ static inline int dma_supported(struct device *dev, u64 mask)
  static inline int dma_mapping_error(struct device *dev, u64 mask)
  {
        struct dma_map_ops *ops = get_dma_ops(dev);
+
+       debug_dma_mapping_error(dev, mask);
        return ops->mapping_error(dev, mask);
  }



Although this is a start, I don't think it is sufficient.

As far as I can tell, there are many missing calls to debug_dma_*() in the various MIPS commone and sub-architecture DMA code.

Really you (or someone) needs to look at *all* the functions in arch/mips/asm/dma-mapping.h, and arch/mips/mm/dma-default.c and find places missing a debug_dma_*().

Thanks,
David Daney

<Prev in Thread] Current Thread [Next in Thread>