linux-mips
[Top] [All Lists]

Re: [RFC 11/13] MIPS: JZ4750D: Add Kbuild files

To: linux-mips@linux-mips.org
Subject: Re: [RFC 11/13] MIPS: JZ4750D: Add Kbuild files
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 24 Oct 2012 19:43:25 +0200
Cc: Maarten ter Huurne <maarten@treewalker.org>, Antony Pavlov <antonynpavlov@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, Lars-Peter Clausen <lars@metafoo.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=B49uMJpUFJNYkYlc4nUYaWHZ9xuDh3kjNlZzciwV80g=; b=EO6dlKgx3poV8r/1W1nvrad1o5F2SAD0waLSqQAjjSAjLJR/Ulr1SVxLDbNECJglzK YANYEvoueki6rMRGYdGHNJdaOy+8p+1cXesnFsyFj8BMmG2gSdUtrk1DPEiWSLVY166P BWEqVydlK45RF4qJTqfs16KMPUmcSEauVNvy217824m6JT57pHsTk/9qesfCGVMp1ROG V5x8+akJzjEJ1IBpoI3jueL59HB9ezlRKR2c3jqI1pKPC4FWQXQ4FeVXepzPkSC9t2ZL x1+6JgElc5S074AqFOIJBDaIgmoYhQLc1ix43C7ArJWA0To6d//eHcnYxWAfmCdLj0y+ UbSg==
In-reply-to: <4796718.WhuB0k6pfC@hyperion>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1351014241-3207-1-git-send-email-antonynpavlov@gmail.com> <1351014241-3207-12-git-send-email-antonynpavlov@gmail.com> <4796718.WhuB0k6pfC@hyperion>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.8.5 (Linux/3.2.0-32-generic; KDE/4.8.5; x86_64; ; )
On Wednesday 24 October 2012 18:16:35 Maarten ter Huurne wrote:
> On Tuesday 23 October 2012 21:43:59 Antony Pavlov wrote:
> > Add the Kbuild files for the JZ4750D architecture and adds JZ4750D support
> > to the MIPS Kbuild files.
> [snip]
> > diff --git a/arch/mips/jz4750d/Platform b/arch/mips/jz4750d/Platform
> > new file mode 100644
> > index 0000000..2e4e050
> > --- /dev/null
> > +++ b/arch/mips/jz4750d/Platform
> > @@ -0,0 +1,3 @@
> > +platform-$(CONFIG_MACH_JZ4750D)    += jz4750d/
> > +cflags-$(CONFIG_MACH_JZ4750D)      +=
> > -I$(srctree)/arch/mips/include/asm/mach-jz4750d
> > +load-$(CONFIG_MACH_JZ4750D)        += 0xffffffff80010000
> 
> What is the purpose of padding the load address to 64 bits?
> 
> The reason I'm asking is that we encountered a bug with that when creating a 
> u-boot image on a 32-bit host machine: the mkimage tool will only parse the 
> first 8 hex digits and then inserts the wrong load address into the uImage.

AFAIR u-boot's mkimage expects 32-bits quantities as a load address, so I would
not be surprised that using this line as-is as an input parameter to mkimage
does not give yout the expected result.
-- 
Florian

<Prev in Thread] Current Thread [Next in Thread>