linux-mips
[Top] [All Lists]

Re: [PATCH] clk: Make the generic clock API available by default

To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH] clk: Make the generic clock API available by default
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Mon, 22 Oct 2012 14:27:11 +0100
Cc: Mike Turquette <mturquette@linaro.org>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Ralf Baechle <ralf@linux-mips.org>, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <20121022130556.GM21164@n2100.arm.linux.org.uk>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1350910970-9095-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20121022130556.GM21164@n2100.arm.linux.org.uk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 22, 2012 at 02:05:57PM +0100, Russell King - ARM Linux wrote:
> On Mon, Oct 22, 2012 at 02:02:50PM +0100, Mark Brown wrote:
> > @@ -327,6 +328,7 @@ config ARCH_AT91
> >     select ARCH_REQUIRE_GPIOLIB
> >     select CLKDEV_LOOKUP
> >     select HAVE_CLK
> > +   select HAVE_CUSTOM_CLK

> This is silly.  If you select "HAVE_CUSTOM_CLK" then isn't it true that
> "HAVE_CLK" should also be selected?  If so, why not have "HAVE_CUSTOM_CLK"
> do that selection and remove it from all these entries?

If we're worrying about that there's the larger point that the effect of
this patch is to make HAVE_CLK meaningless as there will be no platform
for which it's not true.  I was just leaving HAVE_CLK alone for now
ready to circle around on it if we ever manage to get the enabling bit
sorted.

<Prev in Thread] Current Thread [Next in Thread>