[Top] [All Lists]

Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api st

To: Eric Dumazet <>
Subject: Re: [ath9k-devel] [PATCH net-next 00/21] treewide: Use consistent api style for address testing
From: Pavel Roskin <>
Date: Fri, 19 Oct 2012 11:55:17 -0400
Cc: Joe Perches <>,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
In-reply-to: <1350630254.2293.183.camel@edumazet-glaptop>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <1350630254.2293.183.camel@edumazet-glaptop>
On Fri, 19 Oct 2012 09:04:14 +0200
Eric Dumazet <> wrote:

> Yes they are some names discrepancies, thats a big deal.
> And we have alloc_skb() / kfree_skb() / skb_clone() 
> Why not skb_alloc() / skb_free() / skb_clone() ?
> Some people actually know current code by name of functions, they dont
> want to change their mind and having to grep include files and git log
> to learn the new names of an old function, especially when traveling
> and using a laptop.

I agree.

Also, it makes sense to introduce a more consistent name for a function
when it's improved in some way and the callers need to be adjusted or

That way, the old name can be phased out as the code is made compatible
with the new function.

Pavel Roskin

<Prev in Thread] Current Thread [Next in Thread>