linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_fl

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] MIPS: Remove redundant TLB invalidate from pmdp_splitting_flush().
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 18 Oct 2012 13:31:55 +0200
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
In-reply-to: <1350519620-4582-1-git-send-email-ddaney.cavm@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1350519620-4582-1-git-send-email-ddaney.cavm@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 17, 2012 at 05:20:20PM -0700, David Daney wrote:

> diff --git a/arch/mips/mm/pgtable-64.c b/arch/mips/mm/pgtable-64.c
> index 6c9a477..5408bb5 100644
> --- a/arch/mips/mm/pgtable-64.c
> +++ b/arch/mips/mm/pgtable-64.c
> @@ -71,7 +71,7 @@ void pmdp_splitting_flush(struct vm_area_struct *vma,
>       if (!pmd_trans_splitting(*pmdp)) {
>               pmd_t pmd = pmd_mksplitting(*pmdp);
>               set_pmd_at(vma->vm_mm, address, pmdp, pmd);
> -             flush_tlb_range(vma, address, address + HPAGE_SIZE);
> +             /* TLB already flushed by set_pmd_at() */

Thanks, folded into the THP patch.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>