linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h

To: Antony Pavlov <antonynpavlov@gmail.com>
Subject: Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 16 Oct 2012 10:19:33 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Lars-Peter Clausen <lars@metafoo.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=V0PaBpXsL497QKhh6fyZNnLV162t+Rj/q5CWcnNp4eU=; b=zs4J1KEmhV1D3Vf+tq9TR+2ME/uRos+IcvrcAx95D3snBaIh16yYFSXDbYhZFh6Npa HCF8TFRwuLA4YIJJMawSWe+/EmqzmnNqCH4Mc9So/q0AnF36MLRndVH5j0RuY9GBGa6C DWX0EItdpNi4MqGMtDrpe8nfARvpW2TBIDkOVhhHKuIVvczhq1vUgXeWLSgiUvO7OOXh nhnAYdeYUFy8YjT8zApns0xv1zwIWO01X7wNyyTeYlthDgEhvsB0bwh+voxWPu/BdBWi GaTuWLaWJbDSMFj3Zw0X5rdkedo+rr7XHKX7Wupkd8ywffeXAwdnkkDdxWitK2jW1Wg6 gk8Q==
In-reply-to: <1350337127-11315-2-git-send-email-antonynpavlov@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1350337127-11315-1-git-send-email-antonynpavlov@gmail.com> <1350337127-11315-2-git-send-email-antonynpavlov@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Oct 15, 2012 at 11:38 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> The 'uart_port' struct is used in the declaration of
> the jz4740_serial_out() function.

It only needs a forward declaration, as it just references the pointer type.

> This commit adds the missing header file containing
> declaration of the 'uart_port' struct.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  arch/mips/jz4740/serial.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
> index aa5a939..dfc155c 100644
> --- a/arch/mips/jz4740/serial.h
> +++ b/arch/mips/jz4740/serial.h
> @@ -16,6 +16,8 @@
>  #ifndef __MIPS_JZ4740_SERIAL_H__
>  #define __MIPS_JZ4740_SERIAL_H__
>
> +#include <linux/serial_core.h>
> +

I.e. you can just use instead:

    struct uart_port;

>  void jz4740_serial_out(struct uart_port *p, int offset, int value);
>
>  #endif

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>