Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Mon, Oct 15, 2012 at 11:38 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> The 'uart_port' struct is used in the declaration of
> the jz4740_serial_out() function.

It only needs a forward declaration, as it just references the pointer type.

> This commit adds the missing header file containing
> declaration of the 'uart_port' struct.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  arch/mips/jz4740/serial.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
> index aa5a939..dfc155c 100644
> --- a/arch/mips/jz4740/serial.h
> +++ b/arch/mips/jz4740/serial.h
> @@ -16,6 +16,8 @@
>  #ifndef __MIPS_JZ4740_SERIAL_H__
>  #define __MIPS_JZ4740_SERIAL_H__
>
> +#include <linux/serial_core.h>
> +

I.e. you can just use instead:

    struct uart_port;

>  void jz4740_serial_out(struct uart_port *p, int offset, int value);
>
>  #endif

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds