linux-mips
[Top] [All Lists]

Re: [PATCH] mm: huge_memory: Fix build error.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] mm: huge_memory: Fix build error.
From: David Rientjes <rientjes@google.com>
Date: Mon, 15 Oct 2012 13:51:10 -0700 (PDT)
Cc: Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=ZphSaKwJQTYoGuZJtvF1BDTKqVMwUGAEFRDtKMbmExM=; b=GYPwXvmqFjHwmrdeXlZJtrQDw3HpEJkL7eNBxyF2Fx59SODSddoJz2pK2B5+cHfU8J F90ptbkWbSN6wj1Yb4txmp/nSiAILZCsCL07jQAvmQ4FlITrZX5r2+oXaeXJVzzeSDNv 5KhmgjJh0VpMScBKVPWz6Ia36VZvvZvtEYyhXHP3Ifp8uUB3sNC1hMfM9AXFzxjUFuJm 6EPb9D54Q0A20xxgnOiOL9bR/KXIsHyGqDJV31rzJ4bvPQYlYeLVPY+9nJdyA8jWdtQc NJPamppcv8KPg3wZ41q+8M6VNWFj6uHOriaaLWUoWi2Ae1pI2gxRZUcBK+2V0cDAG6NP V1jA==
In-reply-to: <20121015114456.GA30314@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <20121015114456.GA30314@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Mon, 15 Oct 2012, Ralf Baechle wrote:

> Certain configurations won't implicitly pull in <linux/pagemap.h> resulting
> in the following build error:
> 
> mm/huge_memory.c: In function 'release_pte_page':
> mm/huge_memory.c:1697:2: error: implicit declaration of function 
> 'unlock_page' [-Werror=implicit-function-declaration]
> mm/huge_memory.c: In function '__collapse_huge_page_isolate':
> mm/huge_memory.c:1757:3: error: implicit declaration of function 
> 'trylock_page' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> 

This is because CONFIG_HUGETLB_PAGE=n so mempolicy.h doesn't include 
pagemap.h?

> Reported-by: David Daney <david.daney@cavium.com>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Acked-by: David Rientjes <rientjes@google.com>

<Prev in Thread] Current Thread [Next in Thread>