linux-mips
[Top] [All Lists]

Re: [PATCH 05/32 v4] MIPS: Netlogic: use ehci-platform driver

To: "Florian Fainelli" <florian@openwrt.org>
Subject: Re: [PATCH 05/32 v4] MIPS: Netlogic: use ehci-platform driver
From: "Jayachandran C." <jchandra@broadcom.com>
Date: Mon, 8 Oct 2012 19:36:42 +0530
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, "Ralf Baechle" <ralf@linux-mips.org>, "Jayachandran C" <jayachandranc@netlogicmicro.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <1349701906-16481-6-git-send-email-florian@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1349701906-16481-1-git-send-email-florian@openwrt.org> <1349701906-16481-6-git-send-email-florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 08, 2012 at 03:11:19PM +0200, Florian Fainelli wrote:
> The EHCI platform driver is suitable for use by the Netlogic XLR platform
> since there is nothing specific that the EHCI XLR platform driver does.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> Changes in v4:
> - rebased against greg's latest usb-next
> No changes in v3
> 
> Changes in v2:
> - really change driver name to "ehci-platform"
> - slightly reworded commit message
> 
>  arch/mips/netlogic/xlr/platform.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/mips/netlogic/xlr/platform.c 
> b/arch/mips/netlogic/xlr/platform.c
> index 71b44d8..144c5c6 100644
> --- a/arch/mips/netlogic/xlr/platform.c
> +++ b/arch/mips/netlogic/xlr/platform.c
> @@ -15,6 +15,7 @@
>  #include <linux/serial_8250.h>
>  #include <linux/serial_reg.h>
>  #include <linux/i2c.h>
> +#include <linux/usb/ehci_pdriver.h>
>  
>  #include <asm/netlogic/haldefs.h>
>  #include <asm/netlogic/xlr/iomap.h>
> @@ -123,8 +124,12 @@ static u64 xls_usb_dmamask = ~(u32)0;
>               },                                                      \
>       }
>  
> +static struct usb_ehci_pdata xls_usb_ehci_pdata = {
> +     .caps_offset    = 0,
> +};
> +

Do we need to initilaize static data to 0?

JC.


<Prev in Thread] Current Thread [Next in Thread>