linux-mips
[Top] [All Lists]

Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver

To: Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 04 Oct 2012 07:51:01 -0700 (PDT)
Cc: linux-usb@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, Jayachandran C <jayachandranc@netlogicmicro.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=JjLVEC83aUm193mWZqA5NFPkQN1lKu4EaqyGiq0vWkA=; b=Otrrt8vLztKnsgqu4Ew4k5K9irT+a1hSn5GG5q7IxcWXjNCEjVT5KPI84+ifqDltna uncdbi3NPGV5g7Ou9K2HvnYWoRR+zQiVr73BF014znOoZKg6i+BQo91h0pC7a9AYsfpm q0qJomzNC8RDArZReUKP7p+L7AHxQZSSh0eXWAoxL0DQ3yTyYNWUmBHmPwrYqsrFZ39X MGhk640MuL7U4/A8Mu102oWUoGTUR/2C86DmRpdcRBW8XxmrL1gDtIe/ytZeiZq+Tx+A Lfb1Ry431okm1t18M3nfRV6vljc1FO6IGbsOd7ubcKdTtZaMuJnfuloxfAClGt9XXHU3 FqtA==
In-reply-to: <Pine.LNX.4.44L0.1210031151300.1441-100000@iolanthe.rowland.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <Pine.LNX.4.44L0.1210031151300.1441-100000@iolanthe.rowland.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.8.5 (Linux/3.2.0-24-generic; KDE/4.8.5; x86_64; ; )
On Wednesday 03 October 2012 12:47:58 Alan Stern wrote:
> On Wed, 3 Oct 2012, Florian Fainelli wrote:
> 
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> 
> IMO, patches should always have a non-empty changelog.  Even if it is 
> relatively trivial.  The same comment applies to several other patches 
> in this series.
> 
> > ---
> >  arch/mips/netlogic/xlr/platform.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> Does this need to enable CONFIG_USB_EHCI_HCD_PLATFORM is some 
> defconfig file, like you did with the MIPS Loongson 1B?

Netlogic platforms have USB disabled by default in their defconfig, so I'd say 
no, but only for them.

> 
> And likewise for quite a few of the other patches in this series.
> 
> > diff --git a/arch/mips/netlogic/xlr/platform.c 
b/arch/mips/netlogic/xlr/platform.c
> > index 71b44d8..1731dfd 100644
> > --- a/arch/mips/netlogic/xlr/platform.c
> > +++ b/arch/mips/netlogic/xlr/platform.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/serial_8250.h>
> >  #include <linux/serial_reg.h>
> >  #include <linux/i2c.h>
> > +#include <linux/usb/ehci_pdriver.h>
> >  
> >  #include <asm/netlogic/haldefs.h>
> >  #include <asm/netlogic/xlr/iomap.h>
> > @@ -123,6 +124,10 @@ static u64 xls_usb_dmamask = ~(u32)0;
> >             },                                                      \
> >     }
> >  
> > +static struct usb_ehci_pdata xls_usb_ehci_pdata = {
> > +   .caps_offset    = 0,
> > +};
> > +
> >  static struct platform_device xls_usb_ehci_device =
> >                      USB_PLATFORM_DEV("ehci-xls", 0, PIC_USB_IRQ);
> >  static struct platform_device xls_usb_ohci_device_0 =
> > @@ -172,6 +177,7 @@ int xls_platform_usb_init(void)
> >     memres = CPHYSADDR((unsigned long)usb_mmio);
> >     xls_usb_ehci_device.resource[0].start = memres;
> >     xls_usb_ehci_device.resource[0].end = memres + 0x400 - 1;
> > +   xls_usb_ehci_device.dev.platform_data = &xls_usb_ehci_pdata;
> >  
> >     memres += 0x400;
> >     xls_usb_ohci_device_0.resource[0].start = memres;
> 
> Don't you need to change/set the pdev name also?  Likewise for patch 
> 20/25 and 24/25.
> 
> Alan Stern
> 

<Prev in Thread] Current Thread [Next in Thread>