linux-mips
[Top] [All Lists]

Re: [PATCH 07/25] MIPS: Alchemy: use the ehci platform driver

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 07/25] MIPS: Alchemy: use the ehci platform driver
From: Manuel Lauss <manuel.lauss@gmail.com>
Date: Wed, 3 Oct 2012 17:14:21 +0200
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, Manuel Lauss <manuel.lauss@googlemail.com>, Thomas Meyer <thomas@m3y3r.de>, "David S. Miller" <davem@davemloft.net>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=FPlfk/B8izx1anehGg3j6PzGHNf06NbsbVx9eLP1e4w=; b=y5EBoKDcf+2YNKpLMGO5OIC0r8zHPslAcVexSdNM73WYopoFFXlX+xHY+aSOW2gJIK AP9yYD9gi+ZFaYx15AAylXVhne5+SLeKsj40Pqvp4itwMHvQ656ftjB6d4I3SEF7wWka aEHVGLSzNviF3X4kcbOqczYJNqcRfl6puHXH8XIBEf8ICoZuJh3IAjS92Yjtcxz4zw49 QI4X0k/oxg3ZxKjCC06JmcSE+bxG3XfSK0XL4w7L2DpIvlMx1UzFx1tjCnMfnLjTssC/ lRrNTrjFep9PPcmSoTdIbXaPucslE8day1ltQnmFg47Apxa/58OzAaVXXg6AaDJ7Y0Xg 2/yg==
In-reply-to: <1349276601-8371-8-git-send-email-florian@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1349276601-8371-1-git-send-email-florian@openwrt.org> <1349276601-8371-8-git-send-email-florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Oct 3, 2012 at 5:03 PM, Florian Fainelli <florian@openwrt.org> wrote:
> Use the ehci platform driver power_{on,suspend,off} callbacks to perform the
> USB block gate enabling/disabling as what the ehci-au1xxx.c driver does.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
>  arch/mips/alchemy/common/platform.c |   23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/alchemy/common/platform.c 
> b/arch/mips/alchemy/common/platform.c
> index c0f3ce6..57335a2 100644
> --- a/arch/mips/alchemy/common/platform.c
> +++ b/arch/mips/alchemy/common/platform.c
> @@ -17,6 +17,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/serial_8250.h>
>  #include <linux/slab.h>
> +#include <linux/usb/ehci_pdriver.h>
>
>  #include <asm/mach-au1x00/au1000.h>
>  #include <asm/mach-au1x00/au1xxx_dbdma.h>
> @@ -122,6 +123,25 @@ static void __init alchemy_setup_uarts(int ctype)
>  static u64 alchemy_ohci_dmamask = DMA_BIT_MASK(32);
>  static u64 __maybe_unused alchemy_ehci_dmamask = DMA_BIT_MASK(32);
>
> +/* Power on callback for the ehci platform driver */
> +static int alchemy_ehci_power_on(struct platform_device *pdev)
> +{
> +       return alchemy_usb_control(ALCHEMY_USB_EHCI0, 1);
> +}
> +
> +/* Power off/suspend callback for the ehci platform driver */
> +static void alchemy_ehci_power_off(struct platform_device *pdev)
> +{
> +       alchemy_usb_control(ALCHEMY_USB_EHCI0, 0);
> +}
> +
> +static struct usb_ehci_pdata alchemy_ehci_pdata = {
> +       .need_io_watchdog       = 0,

This member doesn't exist.

Manuel

<Prev in Thread] Current Thread [Next in Thread>