linux-mips
[Top] [All Lists]

Re: [PATCH 24/25] MIPS: Alchemy: use the OHCI platform driver

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 24/25] MIPS: Alchemy: use the OHCI platform driver
From: Manuel Lauss <manuel.lauss@gmail.com>
Date: Wed, 3 Oct 2012 17:26:52 +0200
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, Manuel Lauss <manuel.lauss@googlemail.com>, Thomas Meyer <thomas@m3y3r.de>, "David S. Miller" <davem@davemloft.net>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=kkaD6PuS2lnJhb6TdMJXM+VW+vZ5nK2zSpmwm7dkAaE=; b=0HRxO3d/8pDYEjfBSl8DybVZg01hjPLxqeCO9D9Fs82wZiluHwPYxgMKNqDq+lpIkS AvxMnmhk0IEs4z55XYaAbe/CooeZBvjU1ZG0v8goKSSDcnLK/FS6QlRvinsEkboEkbx9 jAgh0sj1y3f5Z/3GAKz0S7B5d9jR28MU6IcTKHmy6LBg4gzkrwz8Zeh45qjbmfuw16c8 PDNLFa5JfohiBomIlrHu9Q5HtRGTP6uKy1eCuid9KlJR3He0hPiQ0ufMtspZ18lGFj1W +9AQhXZcHVkzYxVv2UchNCXaoreK3b8L3p1Pep1yDf3y+fltu8SxLGvNa+9BFpmTQ8ZY FWcw==
In-reply-to: <2608261.j829MQZAuC@flexo>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1349276601-8371-1-git-send-email-florian@openwrt.org> <1349276601-8371-26-git-send-email-florian@openwrt.org> <CAOLZvyHyQGZ=Rs1=k07Saq16aZcntUe8N0Fc5iMoeOTeMpjcSw@mail.gmail.com> <2608261.j829MQZAuC@flexo>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Oct 3, 2012 at 5:24 PM, Florian Fainelli <florian@openwrt.org> wrote:
> On Wednesday 03 October 2012 17:21:37 Manuel Lauss wrote:
>> On Wed, Oct 3, 2012 at 5:03 PM, Florian Fainelli <florian@openwrt.org> wrote:
>> > This also greatly simplifies the power_{on,off} callbacks and make them
>> > work on platform device id instead of checking the OHCI controller base
>> > address like what was done in ohci-au1xxx.c.
>>
>> That was by design -- the base address is far more reliable in identifying
> the
>> correct controller instance than the platform device id.   There are systems
>> in the field which don't use the alchemy/common/platform.c file at all.
>
> Fair enough, but the way it was done previously was very error-prone if the
> base address changed for any reason in the platform code, and you did not
> notice it had to be changed in the OHCI driver too, then it simply did not

Since the Alchemy line is dead this point is moot.


> work. By systems in the field you mean out of tree users? If so, I'd say that
> it's up to you to get them maintained or merged.

I'm not against the patch at all, quite the contrary.

Manuel

<Prev in Thread] Current Thread [Next in Thread>