linux-mips
[Top] [All Lists]

Re: [PATCH v2 2/2] PCI: Provide a default pcibios_update_irq()

To: Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v2 2/2] PCI: Provide a default pcibios_update_irq()
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Thu, 20 Sep 2012 21:19:30 -0600
Cc: Thierry Reding <thierry.reding@avionic-design.de>, Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com>, Russell King <linux@arm.linux.org.uk>, Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>, Geert Uytterhoeven <geert@linux-m68k.org>, Ralf Baechle <ralf@linux-mips.org>, Paul Mundt <lethal@linux-sh.org>, "David S. Miller" <davem@davemloft.net>, Chris Metcalf <cmetcalf@tilera.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, Chris Zankel <chris@zankel.net>, Greg Ungerer <gerg@uclinux.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-system-of-record; bh=Rtw/GkRDlF7fki5PjlDcM6jPF9f0BbRmFMmdNfrs20k=; b=RMOxlJ35LjtETIc2eAIf5cUH41K9yX+YZWyguFHI+Ja1FHr63nesPrT0pUhXqqXBX7 8TV0rMd5R9NA3LsMsmqmjviuadijPg3BJI3n8R5dRJSb8w8dBKAczghZTs+XgkB2Oqnb bAveLvYXu/oYwJi7fa+TMx20Gk+iuv3JpVOQkaX2T8atBH37OwKyl3K8WzOmmMX+Kfw0 E92hJgn5jLAd0Q3JnsnXo68W791Husi1OvnenBKacuw8vgivfOSuUEPtoJeFdl++z7LV 7huHBKlURmJGBjIqL1cU6SMpD3gC+nyGVw7TdTeWKbAx72ivHB1g2WX99YwcBFXfuikJ w8cA==
In-reply-to: <20120920083731.b99255eb8fdeea908d34ed2f@canb.auug.org.au>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1347880974-13615-1-git-send-email-thierry.reding@avionic-design.de> <1347880974-13615-2-git-send-email-thierry.reding@avionic-design.de> <20120920083731.b99255eb8fdeea908d34ed2f@canb.auug.org.au>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Sep 19, 2012 at 4:37 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi,
>
> On Mon, 17 Sep 2012 13:22:54 +0200 Thierry Reding 
> <thierry.reding@avionic-design.de> wrote:
>>
>> diff --git a/drivers/pci/setup-irq.c b/drivers/pci/setup-irq.c
>> index 270ae7b..3d61ce3 100644
>> --- a/drivers/pci/setup-irq.c
>> +++ b/drivers/pci/setup-irq.c
>> @@ -17,6 +17,11 @@
>>  #include <linux/ioport.h>
>>  #include <linux/cache.h>
>>
>> +void __weak pcibios_update_irq(struct pci_dev *dev, int irq)
>> +{
>> +     dev_dbg(&dev->dev, "Assigning IRQ %02d\n", irq);
>> +     pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq);
>> +}
>>
>>  static void
>>  pdev_fixup_irq(struct pci_dev *dev,
>
> Didn't we have a problem with some compiler versions when the weak
> definition was in the same file as the call (there is a call to this
> function in drivers/pci/setup-irq.c)?

There was such a bug, but as far as I know, we aren't worrying about
it anymore: https://lkml.org/lkml/2011/7/4/9

<Prev in Thread] Current Thread [Next in Thread>