linux-mips
[Top] [All Lists]

[PATCH] MIPS: hide USE_OF

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] MIPS: hide USE_OF
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Tue, 18 Sep 2012 11:28:54 +0200
Cc: linux-mips@linux-mips.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=xI/qCL12pns6tTxYIHcox1v2nAhdHt1YUOmhHgaLGnM=; b=WLtjJi3GjMX3z3we8viOc/kl+gkJK5gurIJHX4P+8nmyOKXnVjOQGAIKc065p56nm5 ED1YML9MPBvxOeWTxwCyt8kHkhnPlXVLzIRWNI37ZPD2hSGvk60g4mY5D+HlE80c9dP4 9OQ+08ncmYgdk9DPMxv6zeqrjQdQ0Wr3I+8CslJ02KPINuXCWtF3TAEzwiLeFEVLL0nN SZT01XMA/CZpDEIizDsn9wUnRDVV3x7sbswEarvxot3YgW79ODhAi5L/83Q2sHpt3Kml 012kpHEZN8Kn36iP816ppi4uRlPHe5j2LVM4Ik6c/hawRiFYuImg8DQ2EJ78UnG1pIqO DCqQ==
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Sender: linux-mips-bounce@linux-mips.org
b01da9f1 ("MIPS: Prune some target specific code out of prom.c") removed
the generic implementation of device_tree_init, breaking the kernel
build when manually selecting USE_OF.

Hide the config symbol so it can't be selected acidentially anymore.

Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---

There are two alternatives I have thought of:
a) Make HAVE_OF depend on an additional config symbol selected by targets
 supporting OF.
and
b) create a weak implementation of device_tree_init.

Both depend on the assumption that there are/will be targets that support
booting with and without OF, but I don't know if anyone really wants that.

 arch/mips/Kconfig |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 678931c..529fb19 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2408,12 +2408,10 @@ config SECCOMP
          If unsure, say Y. Only embedded should say N here.
 
 config USE_OF
-       bool "Flattened Device Tree support"
+       bool
        select OF
        select OF_EARLY_FLATTREE
        select IRQ_DOMAIN
-       help
-         Include support for flattened device tree machine descriptions.
 
 endmenu
 
-- 
1.7.10.4


<Prev in Thread] Current Thread [Next in Thread>