linux-mips
[Top] [All Lists]

Re: [PATCH V4 0/3] MIPS: make funcs preempt-safe for non-mipsr2 cpus

To: Jim Quinlan <jim2101024@gmail.com>, ralf@linux-mips.org
Subject: Re: [PATCH V4 0/3] MIPS: make funcs preempt-safe for non-mipsr2 cpus
From: David Daney <ddaney.cavm@gmail.com>
Date: Wed, 05 Sep 2012 16:45:12 -0700
Cc: linux-mips@linux-mips.org, cernekee@gmail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=OxhiQPJa/Hq9bcj5s9ZhwdF/9lzpCPLfeNrQvQz04pE=; b=0BQwBCOJy66MsyV2QIjL2G9Q+V7Y6Idn/kC+YnvonyQzL6XXFIWdnBn+1jv2UMcjrY 0tOXBBkAnhCmzStjCLACq2Hb2VolF43d7SUab0g+4L+cnxGDCO78UDv2kHLIsqBy+USR LBUAzvO39sWdSraBi5fy351NMUK9jP1GLRKuhqODoKy/AOgzHPPP8aTLrd96dCkAOOw5 25ZhS3iAXVxjJS/NSKit28mp/Zltv9klau9VtxnBaM0Kp4sEL/u5YScQErdaDu+O461l EWatulXcCWZS3TXQ89ZCX6fIHeI9u7a12KVtc6gWa6mwr1S1YvVEt2A8LlJfzApTBzPs 6J3A==
In-reply-to: <1346884367-6906-1-git-send-email-jim2101024@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1346884367-6906-1-git-send-email-jim2101024@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0
On 09/05/2012 03:32 PM, Jim Quinlan wrote:
This is V4 of my submission.  Here is a list of requested changes:

   o Extra commit was added for changing an unsigned short to an int.
   o Use of EXTERN_SYMBOL was added to mips-atomic.c and bitops.c,
     as well as the removal of 'extern' in the functions' declarations.
   o Name of funcs changed from atomic_xxx to __mips_xxx in bitops.c.
   o The function comments in bitops.c were tweaked to please
     scripts/kernel-doc.

Here is a list of requested changes that were not done (and why):

   o Suggested optimization of _MIPS_SZLONG and others was not needed
     as mips-atomic.c now includes <asm/irqflags.h>.
   o Suggested fixes to please checkpatch.pl for whitespace before
     newlines in asm strings was attempted but the result made the
     assembly code look more cluttered => no change made.

These were unrequested changes:
   o Changed order of func listings in irqflags.h so that only one
     #ifdef/#endif pair was needed instead of three.

Jim Quinlan



FWIW: I haven't tested these, but...

Acked-by: David Daney <david.daney@cavium.com>


Thanks for your patience,
David Daney

<Prev in Thread] Current Thread [Next in Thread>