linux-mips
[Top] [All Lists]

Re: [PATCH v3 2/3] bcma: add GPIO driver for SoCs

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH v3 2/3] bcma: add GPIO driver for SoCs
From: Rafał Miłecki <zajec5@gmail.com>
Date: Mon, 3 Sep 2012 21:15:44 +0200
Cc: ralf@linux-mips.org, john@phrozen.org, linux-mips@linux-mips.org, linux-wireless@vger.kernel.org, florian@openwrt.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=9zi9DPWS4MkL+lX8mG4g1bHR3Y2ZqNFSnF3Jdunm9Lg=; b=YLpN5z2Rd86PDfqk658IU0RPvfjz3Pn6RM12lkVvpg1P8zyXYX488VYZvvGzFLWs5t YAo/ulbLm/qccqV0+oh8Eu4Q08YEk+kkKos2zWyXlf3OSctxyS3JEXVP+UT1VVU/Ovli qexjHIm/nS/FBIBLUpX4nybZYmdP37WridajsSDWZajEDpHUU0DGn+o8+PKN8bsyzeCJ Iqd/nFWaA3blgUhal9iohgWKKz6pqU+HHHw3105GRrnb8IfWnhVqXqRhrubiMMPKBxmF aTRWzDtm9eQm92y0SNKslbZYGm15cbAbYEJPE57D1rUtElPeF9vCmto4Zlaz0AUOukFJ 2MCg==
In-reply-to: <1346427485-12801-3-git-send-email-hauke@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1346427485-12801-1-git-send-email-hauke@hauke-m.de> <1346427485-12801-3-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2012/8/31 Hauke Mehrtens <hauke@hauke-m.de>:
> +u32 bcma_gpio_in(struct bcma_bus *bus, u32 mask)
> +{
> +       unsigned long flags;
> +       u32 res = 0;
> +
> +       spin_lock_irqsave(&bus->gpio_lock, flags);
> +       res = bcma_chipco_gpio_in(&bus->drv_cc, mask);
> +       spin_unlock_irqrestore(&bus->gpio_lock, flags);
> +
> +       return res;
> +}
> +EXPORT_SYMBOL(bcma_gpio_in);


Could we put here direct ops on ChipCommon regs and drop GPIO
functions from driver_chipcommon.c?

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>