[Top] [All Lists]

Re: [PATCH 2/3] MIPS: JZ4740: Export timer API

To: Thierry Reding <>
Subject: Re: [PATCH 2/3] MIPS: JZ4740: Export timer API
From: Lars-Peter Clausen <>
Date: Sun, 02 Sep 2012 22:27:37 +0200
Cc: Ralf Baechle <>,,, Antony Pavlov <>, Maarten ter Huurne <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
References: <> <> <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20120724 Icedove/3.0.11
On 09/02/2012 10:21 PM, Thierry Reding wrote:
> On Sun, Sep 02, 2012 at 04:45:43PM +0200, Lars-Peter Clausen wrote:
>> On 09/02/2012 11:52 AM, Thierry Reding wrote:
>>> This is a prerequisite for allowing the PWM driver to be converted to
>>> the PWM framework.
>>> Signed-off-by: Thierry Reding <>
>> I'd prefer to keep the timer functions inline, some of them are called quite
>> often in the system clock code.
> I've opted for this variant because it better hides the register values.
> If the functions are inlined it also means the complete register
> definitions need to go into timer.h. If you don't think that's an issue,
> I can update the patch accordingly.

It's not pretty, but it should be ok. Having a single global function for each
and every register access is kind of ugly too.

- Lars

<Prev in Thread] Current Thread [Next in Thread>