linux-mips
[Top] [All Lists]

Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular depen

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency
From: Jim Quinlan <jim2101024@gmail.com>
Date: Thu, 30 Aug 2012 16:35:35 -0400
Cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CPbZ80Q2xWfpbZUnGDkytDBwt7c3iBvfah4VBYkcvqY=; b=weHB9kIUNbX1lUe8Z54+TzI2L6oDj3neJuNiF6iE75H/3jcdm5FfPsS2dabEUpoWgI z0p6lmwYh4592oVNGhiIQCZvsxex+lFWPlxt7i/wKiav/pNiGHVIrzFH4wIs00pTbVm6 h+457057KDGiNHjtTq5eNg/5ag6S4YmIiG7aSs5ss8D5M7mGZKGhI73/FHP2hkpsqThF z5e7seWks/MLE3ttBbM0MW4im8rEhLfINvF7ZD5V0ka0o2ubL0e3oKCIHHx1xUHcfKZG W3CzIv50btOL+4G5auFUpyRDp5S78DT7zdFqGhRIirYhib0Mfsw4hyQOzVO4MuMZZUhJ joGA==
In-reply-to: <20120830141525.GD23288@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1346279647-27955-1-git-send-email-jim2101024@gmail.com> <503E9F66.9030200@gmail.com> <CANCKTBsXhKNtNJxYhyn4Ygt=c3=4ZT-quB3L1XJVFC4y-mWM7Q@mail.gmail.com> <20120830141525.GD23288@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
Are you saying you want me to outline most of the functions in
asm/bitops.h , or do you want me somehow outline just the "else"
clause that invokes raw_local_irq_{save_restore}?

Jim

On Thu, Aug 30, 2012 at 10:15 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Thu, Aug 30, 2012 at 10:06:30AM -0400, Jim Quinlan wrote:
>
>> I'm not sure the tangle is so easily undone.  The first dependency I see is
>>
>> asm-offsets.c
>> asm/processors.h
>> linux/cpumask.h
>> linux/kernel.h
>> linux/bitops.h
>> asm/bitops.h
>> linux/irqflags.h
>> asm/irqflags.h
>>
>> When compared to other architectures, the MIPS asm/bitops.h seems to
>> include more files at the top, including linux/irqflags.h.
>> Any suggestions?
>
> This is because MIPS bitops for some ancient processors which don't have
> atomic operations and Cavium cnMIPS cores where disabling interrupts is
> faster than the atomic operations are implemented by disabling interrupts.
>
> This makes these atomic operations relativly bloated in terms of code size
> generated and may it'd be a good idea to outline the bits.  With a bit
> of luck we even get better cache locality - and fewer header file
> inclusions.
>
>   Ralf

<Prev in Thread] Current Thread [Next in Thread>