linux-mips
[Top] [All Lists]

Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular depen

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH V2 1/2] asm-offsets.c: adding #define to break circular dependency
From: Jim Quinlan <jim2101024@gmail.com>
Date: Thu, 30 Aug 2012 10:06:30 -0400
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ds5dtQSS05ZFwRoHZDxfUXc+9Trd3qFK6v7+iFUn8+g=; b=0oDqDtkiP7xMjdKaBQJ4l1gKtQtSeAxGBqik//qtfZASivtznY7NEE8iEVfTVh5ZNA COjNPYt8aMdpXjmx2Pt5R1UBNtwXDU70PjZkSoKUznIHSSdNEfokvVPRAuDVipT51rrw Pt7gc3PR5gLkuuhK5dFc4DG37z83Oa3h0ur+O/le26V6sqjTDvr4M9nvEiwBFUkAJ7fn xhDiFafM8hTYORjVoXcdWHj/55TGKPs0TZarMb9NPfHNM3XX/Vt7UM33QmETvoYcbTAt eghNHLPob/V8ESQracm6BeVuYEOBEwfyWiNcR/SkzLWdrqEU0MhNX5BWqmn2Go7WTyiP NrSQ==
In-reply-to: <503E9F66.9030200@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1346279647-27955-1-git-send-email-jim2101024@gmail.com> <503E9F66.9030200@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
I'm not sure the tangle is so easily undone.  The first dependency I see is

asm-offsets.c
asm/processors.h
linux/cpumask.h
linux/kernel.h
linux/bitops.h
asm/bitops.h
linux/irqflags.h
asm/irqflags.h

When compared to other architectures, the MIPS asm/bitops.h seems to
include more files at the top, including linux/irqflags.h.
Any suggestions?

On Wed, Aug 29, 2012 at 7:01 PM, David Daney <ddaney.cavm@gmail.com> wrote:
> On 08/29/2012 03:34 PM, Jim Quinlan wrote:
>>
>> irqflags.h depends on asm-offsets.h, but asm-offsets.h depends
>> on irqflags.h when generating asm-offsets.h.
>
>
> What is there in irqflags.h that is required by asm-offsets.c?
>
> Why can't the include tangle be undone so that that part can be factored out
> to a separate file?
>
>
>
>
>> Adding a definition
>> to the top of asm-offsets.c allows us to break this circle.  There
>> is a similar define in bounds.c
>>
>> Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
>> ---
>>   arch/mips/kernel/asm-offsets.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/mips/kernel/asm-offsets.c
>> b/arch/mips/kernel/asm-offsets.c
>> index 6b30fb2..035f167 100644
>> --- a/arch/mips/kernel/asm-offsets.c
>> +++ b/arch/mips/kernel/asm-offsets.c
>> @@ -8,6 +8,7 @@
>>    * Kevin Kissell, kevink@mips.com and Carsten Langgaard,
>> carstenl@mips.com
>>    * Copyright (C) 2000 MIPS Technologies, Inc.
>>    */
>> +#define __GENERATING_OFFSETS_S
>>   #include <linux/compat.h>
>>   #include <linux/types.h>
>>   #include <linux/sched.h>
>>
>

<Prev in Thread] Current Thread [Next in Thread>