linux-mips
[Top] [All Lists]

Re: [PATCH V4] usb: gadget: bcm63xx UDC driver

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH V4] usb: gadget: bcm63xx UDC driver
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Mon, 27 Aug 2012 22:46:13 +0200
Cc: balbi@ti.com, ralf@linux-mips.org, sebastian@breakpoint.cc, stern@rowland.harvard.edu, linux-mips@linux-mips.org, linux-usb@vger.kernel.org
In-reply-to: <2e70dcfde41aee0d733449013ac80ace@localhost>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <2e70dcfde41aee0d733449013ac80ace@localhost>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Aug 25, 2012 at 12:38:52PM -0700, Kevin Cernekee wrote:
> Driver for the "USB20D" / "USBD" block on BCM6328, BCM6368, BCM6816,
> BCM6362, BCM3383, and others.

I don't see anything worth to object.
Acked-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>

One little question: Felipe suggested to replace the workqueue by a threaded
interrupt. You schedule the workqueue in interrupt context and once in ep0
enqueue. The enqueue should be fine by executing one round and waiting for the
interrupt. Any reason why you suggested against it?

Sebastian

<Prev in Thread] Current Thread [Next in Thread>