Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

[John Crispin <john@phrozen.org>]

On 21/08/12 20:40, David Daney wrote:
> On 08/21/2012 11:35 AM, John Crispin wrote:
>> On 21/08/12 20:33, David Daney wrote:
>>> On 08/21/2012 11:23 AM, John Crispin wrote:
>>>> On 11/05/12 23:34, David Daney wrote:
>>>>> From: David Daney <david.daney@cavium.com>
>>>>>
>>>>> Add the driver, link it into the kbuild system and provide device tree
>>>>> binding documentation.
>>>>>
>>>>> Signed-off-by: David Daney <david.daney@cavium.com>
>>>>
>>>> Thanks, queued for 3.7.
>>>>
>>>
>>> This cannot go in like this.
>>>
>>> There were a bunch of requests by other maintainers that were never
>>> done.  Also since it is in a foreign subsystem, it at a minimum needs
>>> some additional Acked-bys
>>
>> hmmm ... you are right about the Acked-by ... i forgot to merge add it
>> ...
>>
>> i did ask you about this on IRC and you said the driver was ok to be
>> merged like this. inside the thread linus wllej at some point says that
>> his comment was bogus if i am not mistaken ?
> 
> OK, I think I won't answer this type of question on IRC in the future. I
> really should have looked at it in more detail.  But at the end of the
> day, I need to fix it up before it can go in.
> 
> David Daney

i agree, i just removed it from the queue ...