linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 21 Aug 2012 11:40:45 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=KF1gWiQmvYTdxwnugpdl2bhaU1J/0I8Jjc96YpS5GVY=; b=UFlwolO4/9KmrmyTEWCfJcqMZBQnPc2vkcLCOZmJD8OHgnwGLIr9f46w7KA+pTkO7y JKCGm+LDe4qC+kVZN0u/XWPSHC4zt/mGFVAR/dlblVDlDSLd+GFFPQN93LP1uggg/hcB uKAd5KwjEEmTBFS6B6s7Zp1uWSOyiO6TRlQiHdQXn5rllFRMXoIUP5+QaGEVU3jaChiE X6OVdT494zUMMr0DnWg903OFmupATlSUkq+roy2oof6Bg/gdLtrvpPYYbj8nZ+d7atc+ Q6VpbVuAOUliqwsL4ixghmMHGtLvUtKKHe8OZnAu6pZt3QmsMJ1tHiE2IDI4gTYUrw6J dRXw==
In-reply-to: <5033D4DC.6050902@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1336772086-17248-1-git-send-email-ddaney.cavm@gmail.com> <1336772086-17248-3-git-send-email-ddaney.cavm@gmail.com> <5033D22E.2050307@phrozen.org> <5033D48B.8050903@gmail.com> <5033D4DC.6050902@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0
On 08/21/2012 11:35 AM, John Crispin wrote:
On 21/08/12 20:33, David Daney wrote:
On 08/21/2012 11:23 AM, John Crispin wrote:
On 11/05/12 23:34, David Daney wrote:
From: David Daney <david.daney@cavium.com>

Add the driver, link it into the kbuild system and provide device tree
binding documentation.

Signed-off-by: David Daney <david.daney@cavium.com>

Thanks, queued for 3.7.


This cannot go in like this.

There were a bunch of requests by other maintainers that were never
done.  Also since it is in a foreign subsystem, it at a minimum needs
some additional Acked-bys

hmmm ... you are right about the Acked-by ... i forgot to merge add it ...

i did ask you about this on IRC and you said the driver was ok to be
merged like this. inside the thread linus wllej at some point says that
his comment was bogus if i am not mistaken ?

OK, I think I won't answer this type of question on IRC in the future. I really should have looked at it in more detail. But at the end of the day, I need to fix it up before it can go in.

David Daney



<Prev in Thread] Current Thread [Next in Thread>