linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
From: John Crispin <john@phrozen.org>
Date: Tue, 21 Aug 2012 20:35:08 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <5033D48B.8050903@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1336772086-17248-1-git-send-email-ddaney.cavm@gmail.com> <1336772086-17248-3-git-send-email-ddaney.cavm@gmail.com> <5033D22E.2050307@phrozen.org> <5033D48B.8050903@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16
On 21/08/12 20:33, David Daney wrote:
> On 08/21/2012 11:23 AM, John Crispin wrote:
>> On 11/05/12 23:34, David Daney wrote:
>>> From: David Daney <david.daney@cavium.com>
>>>
>>> Add the driver, link it into the kbuild system and provide device tree
>>> binding documentation.
>>>
>>> Signed-off-by: David Daney <david.daney@cavium.com>
>>
>> Thanks, queued for 3.7.
>>
> 
> This cannot go in like this.
> 
> There were a bunch of requests by other maintainers that were never
> done.  Also since it is in a foreign subsystem, it at a minimum needs
> some additional Acked-bys

hmmm ... you are right about the Acked-by ... i forgot to merge add it ...

i did ask you about this on IRC and you said the driver was ok to be
merged like this. inside the thread linus wllej at some point says that
his comment was bogus if i am not mistaken ?

John

<Prev in Thread] Current Thread [Next in Thread>