linux-mips
[Top] [All Lists]

Re: [PATCH] usb: gadget: bcm63xx UDC driver

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH] usb: gadget: bcm63xx UDC driver
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Mon, 20 Aug 2012 21:52:31 +0200
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>, balbi@ti.com, ralf@linux-mips.org, linux-mips@linux-mips.org, linux-usb@vger.kernel.org
In-reply-to: <CAJiQ=7CADk_75U5=OQH8vXA=xtj-U=TbBhXzC8JfUGbYEKmxng@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <97cb21b8063a02a9664baf8b749ae200@localhost> <20120819201714.GA3152@breakpoint.cc> <CAJiQ=7CADk_75U5=OQH8vXA=xtj-U=TbBhXzC8JfUGbYEKmxng@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Aug 19, 2012 at 01:53:26PM -0700, Kevin Cernekee wrote:
> > According to this code, i in iudma[] can be in 1..5. You could have more 
> > than
> > one IRQ. The comment above this for loop is point less. So I think if you 
> > can
> > only have _one_ idma irq than you could remove the for loop in
> > bcm63xx_udc_data_isr().
> 
> There are 6 IUDMA channels, and each one always has a dedicated
> interrupt line.  IRQ resource #0 is the control (vbus/speed/cfg/etc.)
> IRQ, and IRQ resources #1-6 are the IUDMA (IN/OUT data) IRQs.  Maybe
> it would be good to add a longer comment to clarify this?

Now that I look at the code again, I see what I've missed. So you can have
multiple irqs in the range #1-6. Why not pass the iudma struct then?
Passing the struct instead of a range is good thing.

Sebastian

<Prev in Thread] Current Thread [Next in Thread>