linux-mips
[Top] [All Lists]

Re: PCI Section mismatch error in linux-next.

To: Thierry Reding <thierry.reding@avionic-design.de>
Subject: Re: PCI Section mismatch error in linux-next.
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri, 17 Aug 2012 15:25:22 -0600
Cc: David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, linux-pci@vger.kernel.org, linux-mips <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-system-of-record; bh=GbZfjBJFh5CdxV/BvqMTZw9hYzK4UjTQTyebycwzZJQ=; b=bi9hmymbNwKp/ezGGhb7Rg9tIqfIDpl+gauO2yg0WfJfeRzxv26NU/Vx/LUmxqCQnd 7JnXQ4WUYO9Q8L8Gth9+j6GbikQHCierXKoJqeQMh2VrRc4NBhKKsUYON/QndQXVV8x2 SVsEvWGqwVIKgH0/hSPZKkjEB8SPuKegj5dL3JZvh7Wgy+eIy86W4kpeVaqv1IGpGomR 7mOlPktjoOTC1aZktp1tMoPkjGRyzd1Zhzk2E23Rx9GMJ7eiEmB6CoKTpMqm9VSHhKOK 9jiZnznFetEQFFvLuKLnpC2MEDyHj8AY5u0br1fRIULIUx1A9qXCqbBjmu1LWLCGSV1Z q/Xg==
In-reply-to: <20120817210718.GA14842@avionic-0098.mockup.avionic-design.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <502E8115.90507@gmail.com> <CAErSpo7a77wAxrgZYfg_UdqLEtEf0wUxcbxTghnR7HbRsncKRQ@mail.gmail.com> <20120817182931.GA27391@avionic-0098.adnet.avionic-design.de> <CAErSpo6xhbpmd-rnLqKp9SuRQCp5a7jUzKhz0n6zGGLNHybWqA@mail.gmail.com> <20120817200755.GA16021@avionic-0098.adnet.avionic-design.de> <CAErSpo4XX7mQBmJfYWzmXCSDAt4BzZoJV6gU9__409K=fpvC6A@mail.gmail.com> <20120817204839.GA2017@avionic-0098.mockup.avionic-design.de> <20120817210718.GA14842@avionic-0098.mockup.avionic-design.de>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Aug 17, 2012 at 3:07 PM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> On Fri, Aug 17, 2012 at 10:48:39PM +0200, Thierry Reding wrote:
>> On Fri, Aug 17, 2012 at 02:39:34PM -0600, Bjorn Helgaas wrote:
> [...]
>> > Well, maybe you just need to turn on CONFIG_HOTPLUG.  How would that
>> > affect you?  I think we would still have to change some __inits to
>> > __devinit, including pcibios_update_irq(), but it might be more
>> > manageable.
>>
>> You said that depending on HOTPLUG wouldn't be enough because it would
>> exclude reenumeration at runtime if HOTPLUG wasn't defined. Also it is
>> theoretically possible to build a kernel without HOTPLUG but have the
>> enumeration start after init because of deferred probing. Those cases
>> won't work if we keep __init or __devinit respectively, right?
>
> Another possibility would be to make PCI select HOTPLUG or depend on it.
> That way it would be made sure that __devinit wouldn't cause all the
> functions to be discarded after init.

There's been some discussion recently about whether CONFIG_HOTPLUG is
worth keeping any more, but nothing's been resolved yet.  If we did
decide to remove CONFIG_HOTPLUG, or require it for PCI, I would rather
just remove all the __devinit annotations because they'd be
superfluous.

> Also, using PCI without HOTPLUG is sort of contradictory.

I'm not sure I follow this one.  I can easily imagine embedded systems
that use PCI internally but have no slots or connectors, so there's no
possibility of anything changing.

<Prev in Thread] Current Thread [Next in Thread>