linux-mips
[Top] [All Lists]

Re: PCI Section mismatch error in linux-next.

To: Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: PCI Section mismatch error in linux-next.
From: Thierry Reding <thierry.reding@avionic-design.de>
Date: Fri, 17 Aug 2012 20:29:31 +0200
Cc: David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, linux-pci@vger.kernel.org, linux-mips <linux-mips@linux-mips.org>
In-reply-to: <CAErSpo7a77wAxrgZYfg_UdqLEtEf0wUxcbxTghnR7HbRsncKRQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <502E8115.90507@gmail.com> <CAErSpo7a77wAxrgZYfg_UdqLEtEf0wUxcbxTghnR7HbRsncKRQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 17, 2012 at 11:44:31AM -0600, Bjorn Helgaas wrote:
> On Fri, Aug 17, 2012 at 11:36 AM, David Daney <ddaney.cavm@gmail.com> wrote:
> > For MIPS, Thierry Reding's patch in linux-next (PCI: Keep pci_fixup_irqs()
> > around after init) causes:
> >
> > WARNING: vmlinux.o(.text+0x22c784): Section mismatch in reference from the
> > function pci_fixup_irqs() to the function .init.text:pcibios_update_irq()
> >
> > The MIPS implementation of pcibios_update_irq() is __init, so there is
> > conflict with the removal of __init from pci_fixup_irqs() and
> > pdev_fixup_irq().
> >
> > Can you guys either remove the patch from linux-next, or improve it to also
> > fix up any architecture implementations of pdev_update_irq()?
> 
> Crap, there are lots of arches with this issue.  I'll fix it up.
> Thanks for pointing it out!

Oh wow... looks like I've opened a can of worms there. This requires
quite a lot of other functions to have their annotations removed as
well. Bjorn, how do you want to handle this?

Thierry

Attachment: pgp_a2XeVGZWI.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>