| To: | John Crispin <blogic@openwrt.org> |
|---|---|
| Subject: | Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master |
| From: | Shubhrajyoti Datta <omaplinuxkernel@gmail.com> |
| Date: | Thu, 16 Aug 2012 15:10:56 +0530 |
| Cc: | Wolfram Sang <w.sang@pengutronix.de>, linux-i2c@vger.kernel.org, linux-mips@linux-mips.org, Thomas Langer <thomas.langer@lantiq.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3CiwWcZRnf/p4trTEXZggrmxVTqRWzpHUp7aSCdurOU=; b=KHOoz6H/hyWuwL/60AjQVR+t6uWH/wY1DTSa6SZckxCUNrbh+Tuokurqk+5f2KgZEE kHaEYEUqBwS3KBX7NE39uUz7XmW0r1ZW8auvLXbBZ2SDLnj+EGZdCUIBk4xs0g6gr3Br 1dThBjh+SOGLkdDqY0FmRQ6YYrSlgbKIJv6FKWM6PidECeSGw/2DiOSWdho9pcIwQf5l wQrFg47MzGcvQlSmWAgQyldr2uYafwImygygDBqUzUXMD3yKoXlkRrVDNKMjcoeM38wg Vm1/RqemW4jiYJFTKxOL9dZW/20Cism7qFVLXBA6SxySEUT26SCYIyRH8KRYP1RW9S7c jSjg== |
| In-reply-to: | <502CB736.6010107@openwrt.org> |
| List-archive: | <http://www.linux-mips.org/archives/linux-mips/> |
| List-help: | <mailto:ecartis@linux-mips.org?Subject=help> |
| List-id: | linux-mips <linux-mips.eddie.linux-mips.org> |
| List-owner: | <mailto:ralf@linux-mips.org> |
| List-post: | <mailto:linux-mips@linux-mips.org> |
| List-software: | Ecartis version 1.0.0 |
| List-subscribe: | <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips> |
| List-unsubscribe: | <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips> |
| References: | <1345102448-4612-1-git-send-email-blogic@openwrt.org> <CAM=Q2cvCmKMkQjWd0nvuvMMkNt3sH-AcupCq_KzM7EXDuD_-wQ@mail.gmail.com> <502CB736.6010107@openwrt.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
Hi John, On Thu, Aug 16, 2012 at 2:32 PM, John Crispin <blogic@openwrt.org> wrote: > Hi Shubhrajyoti, > > Thanks for the comments, I just noticed that clk_put() is also missing > and that the clock gate should be deactivated upon a rmmod ... i will > fix all of these and resend the patch. There are two things 1> Relinquishing the handle. I think clk_put does that not sure. 2> Gating , ie deactivating the clock the best place for this to happen is when there is no transfer. However that aggression in PM can happen later. > > John |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 4/4] MIPS: lantiq: enable pci clk conditional for xrx200 SoC, John Crispin |
|---|---|
| Next by Date: | Re: [PATCH] MIPS: fix module.c build for 32 bit, Rusty Russell |
| Previous by Thread: | Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master, John Crispin |
| Next by Thread: | [PATCH] SPI: MIPS: lantiq: adds spi-xway, John Crispin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |