linux-mips
[Top] [All Lists]

Re: [PATCH V5 13/18] drm: Define SAREA_MAX for Loongson (PageSize = 16KB

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V5 13/18] drm: Define SAREA_MAX for Loongson (PageSize = 16KB).
From: Huacai Chen <chenhuacai@gmail.com>
Date: Thu, 16 Aug 2012 08:43:06 +0800
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>, dri-devel@lists.freedesktop.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9nFHNpM33JVy9QgNk+CCd+5Wku2cC3K3rtWjjuSIdpM=; b=BG1HHSss9zowIHpLlKqGXeA8ns7kBJb3gqZ9LrjssyisXkE1fHQHwTBRhOh2ZAyMK4 DGR8N5A137Y5hYblEudScdMONJch/ZHol1jnZFQrKAX4zO0dj5VSl90OPc7rhEK5+EqY XUEZckal36BHCERzZdtBTAQMKfkn8SsOBbihE9lSnNZ6/tMbgPdqEzO9o582txWD6rDn iZIaNuW4jPU26jbCpkAuuRWYQ+J/c2dPHf32J8a/zB5y7oaMjOz7WOdJTZRT006mFIK8 BwHeEOE7eJULliUjbkQjifhVxywxZPOBgjzB929T6ArrcTjPcfaSZgSqKRIt4MG+Q6TT fbSw==
In-reply-to: <20120815213126.GC15844@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1344677543-22591-1-git-send-email-chenhc@lemote.com> <1344677543-22591-14-git-send-email-chenhc@lemote.com> <20120815213126.GC15844@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Thu, Aug 16, 2012 at 5:31 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Sat, Aug 11, 2012 at 05:32:18PM +0800, Huacai Chen wrote:
>
>> Subject: [PATCH V5 13/18] drm: Define SAREA_MAX for Loongson (PageSize = 
>> 16KB).
>
> But your code doesn't define it just for Loongsson as the log message claims
> but rather for all MIPS.
>
>> diff --git a/include/drm/drm_sarea.h b/include/drm/drm_sarea.h
>> index ee5389d..1d1a858 100644
>> --- a/include/drm/drm_sarea.h
>> +++ b/include/drm/drm_sarea.h
>> @@ -37,6 +37,8 @@
>>  /* SAREA area needs to be at least a page */
>>  #if defined(__alpha__)
>>  #define SAREA_MAX                       0x2000U
>> +#elif defined(__mips__)
>> +#define SAREA_MAX                       0x4000U
>
> How about replacing this whole #ifdef mess with something like:
>
> #include <linux/kernel.h>
> #include <asm/page.h>
>
> /* Intel 830M driver needs at least 8k SAREA */
> #define SAREA_MAX       max(PAGE_SIZE, 0x2000U)
>
> MIPS also uses 64K page size and your patch as posted would break with 64k
> pages.
Yes, I think this is better. Thank you.
>
>   Ralf

<Prev in Thread] Current Thread [Next in Thread>