linux-mips
[Top] [All Lists]

Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.
From: Huacai Chen <chenhuacai@gmail.com>
Date: Thu, 16 Aug 2012 08:39:40 +0800
Cc: John Crispin <john@phrozen.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IMFt08BmZSF90uBH4kvUKoq8ik6HUOlhfEJuNoeY+Ng=; b=Q4XtrKWIsZ4dCvMA7GJHxJ9RfgWF1K/EY1Aqt3xIah2ljYvzAxXFj/Llqi0V5o/kBx DaNDg0boqVeyIiicxP1AylnXAcBg6pgbmn3H+3s/KPjBnAgas31mNqJQvXMtMKUhHxke Do4ij7XhfTzACeiQTh9rfmBusLrZIixN958BdSaM2LCigqg5/y8B2K+C4FR7WRLwdvQn PIkbYaHVXAd+T76f/eTgkQeedu2qsrfY980i8+r1SisiMFvaGcxrMxHqJxIQiZ2/TN+Y 3Pv0ARgsB8HGW2OADvAKeGyvFCuCWIFIT0+dzDEbUc4QkzOsNXi1PJJXZa/sQUXT6Af1 XMAA==
In-reply-to: <20120815193617.GA15844@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1344677543-22591-1-git-send-email-chenhc@lemote.com> <1344677543-22591-2-git-send-email-chenhc@lemote.com> <50274467.90509@phrozen.org> <20120815193617.GA15844@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
OK, I'm reworking the patch series.

On Thu, Aug 16, 2012 at 3:36 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Sun, Aug 12, 2012 at 07:51:35AM +0200, John Crispin wrote:
>
>> On 11/08/12 11:32, Huacai Chen wrote:
>> >  #define PRID_IMP_LOONGSON2 0x6300
>> > +#define PRID_IMP_LOONGSON3 0x6300
>> >
>>
>> as PRID_IMP_LOONGSON2 and PRID_IMP_LOONGSON3 share the same value, its
>> not really a uniq ID anymore. Maybe change this to a common PRID ?
>>
>> patch 2/18 does not even make use of this new symbol inside
>> arch/mips/kernel/cpu-probe.c
>
> PRID_IMP_LOONGSON3 is not even being used in the series.  If it was, it'd
> cause a duplicate case label in the usual switch construction in
> cpu_probe_legacy().
>
> Huacai, can you please resend with this symbol removed?  Thanks.
>
>   Ralf
>

<Prev in Thread] Current Thread [Next in Thread>