linux-mips
[Top] [All Lists]

Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 15 Aug 2012 21:36:18 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <50274467.90509@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1344677543-22591-1-git-send-email-chenhc@lemote.com> <1344677543-22591-2-git-send-email-chenhc@lemote.com> <50274467.90509@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Aug 12, 2012 at 07:51:35AM +0200, John Crispin wrote:

> On 11/08/12 11:32, Huacai Chen wrote:
> >  #define PRID_IMP_LOONGSON2 0x6300
> > +#define PRID_IMP_LOONGSON3 0x6300
> >  
> 
> as PRID_IMP_LOONGSON2 and PRID_IMP_LOONGSON3 share the same value, its
> not really a uniq ID anymore. Maybe change this to a common PRID ?
> 
> patch 2/18 does not even make use of this new symbol inside
> arch/mips/kernel/cpu-probe.c

PRID_IMP_LOONGSON3 is not even being used in the series.  If it was, it'd
cause a duplicate case label in the usual switch construction in
cpu_probe_legacy().

Huacai, can you please resend with this symbol removed?  Thanks.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>