Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.

[Ralf Baechle <ralf@linux-mips.org>]

On Sun, Aug 12, 2012 at 07:51:35AM +0200, John Crispin wrote:

> On 11/08/12 11:32, Huacai Chen wrote:
> >  #define PRID_IMP_LOONGSON2 0x6300
> > +#define PRID_IMP_LOONGSON3 0x6300
> >  
> 
> as PRID_IMP_LOONGSON2 and PRID_IMP_LOONGSON3 share the same value, its
> not really a uniq ID anymore. Maybe change this to a common PRID ?
> 
> patch 2/18 does not even make use of this new symbol inside
> arch/mips/kernel/cpu-probe.c

PRID_IMP_LOONGSON3 is not even being used in the series.  If it was, it'd
cause a duplicate case label in the usual switch construction in
cpu_probe_legacy().

Huacai, can you please resend with this symbol removed?  Thanks.

  Ralf