linux-mips
[Top] [All Lists]

Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)

To: Kelvin Cheung <keguang.zhang@gmail.com>
Subject: Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED)
From: Florian Fainelli <florian@openwrt.org>
Date: Tue, 14 Aug 2012 14:49:04 +0200
Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, ralf@linux-mips.org, linux-mips@linux-mips.org, gregkh@suse.de, wuzhangjin@gmail.com, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=1JcyFwKHflNO8HJcWCHSVYN/dKuA1FpaoyJDSjlAVno=; b=ebUvFrFpscDWBl5QddU5w/PZITi9itTQFp4bkl4aW6c1KbK8XCRbTvuIytX45wbLbM SV4cIZioHrza57A9WsMEm+Fxecl3yJ/vqLiCB8tn50KkEuNgzcfmUyfxcHF+1CYgW1q9 at1R/JR2lOIl5xeP0LxGqRLflT6gPSM4fDrQSVrAO0uZsk8+LxE13X4xbeOdM3hrpNjd NUGQysO9n/I60JfOk83Z0CwEcaq+dzgmgVKX35azq4GYjHVgtRAN1hvhOLCdn4xG0SuX wa08AioZyUT57mWjXBX1xjiXxywrChmTAbVkiH8i3+Z9zQtsWq3hDv2SDh5koG2hoXfV Nv1w==
In-reply-to: <1326868876-20271-1-git-send-email-keguang.zhang@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: OpenWrt
References: <1326868876-20271-1-git-send-email-keguang.zhang@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.8.4 (Linux/3.2.0-24-generic; KDE/4.8.4; x86_64; ; )
Hello Kelvin,

On Wednesday 18 January 2012 14:41:16 Kelvin Cheung wrote:
> Use ehci_setup() in ehci_ls1x_reset().
> 
> The Loongson1x SoCs have a built-in EHCI controller.
> This patch adds the necessary glue code to make the generic EHCI
> driver usable for them.
> 
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---

I do not see this driver doing anything fancy which would require an entirely 
new ehci implementation so consider using the generic ehci platform driver 
(drivers/usb/host/ehci-platforms.c) instead.

>  drivers/usb/Kconfig          |    1 +
>  drivers/usb/host/ehci-hcd.c  |    5 ++
>  drivers/usb/host/ehci-ls1x.c |  159 
++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 165 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/usb/host/ehci-ls1x.c
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 85d5a01..78ac78b 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -68,6 +68,7 @@ config USB_ARCH_HAS_EHCI
>       default y if ARCH_MSM
>       default y if MICROBLAZE
>       default y if SPARC_LEON
> +     default y if MACH_LOONGSON1

Do this in arch/mips/Kconfig instead.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH V6 4/5] USB: Add EHCI bus glue for Loongson1x SoCs (UPDATED), Florian Fainelli <=