Re: [PATCH V5 04/18] MIPS: Loongson: Make Loongson-3 to use BCD format for RTC.

[John Crispin <john@phrozen.org>]

On 11/08/12 11:32, Huacai Chen wrote:
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> Signed-off-by: Hongliang Tao <taohl@lemote.com>
> Signed-off-by: Hua Yan <yanh@lemote.com>
> ---
>  arch/mips/include/asm/mach-loongson/mc146818rtc.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/mips/include/asm/mach-loongson/mc146818rtc.h 
> b/arch/mips/include/asm/mach-loongson/mc146818rtc.h
> index ed7fe97..6b10159 100644
> --- a/arch/mips/include/asm/mach-loongson/mc146818rtc.h
> +++ b/arch/mips/include/asm/mach-loongson/mc146818rtc.h
> @@ -27,7 +27,11 @@ static inline void CMOS_WRITE(unsigned char data, unsigned 
> long addr)
>       outb_p(data, RTC_PORT(1));
>  }
>  
> +#ifdef CONFIG_CPU_LOONGSON3
> +#define RTC_ALWAYS_BCD       1
> +#else
>  #define RTC_ALWAYS_BCD       0
> +#endif
>  


maybe use a static inline that checks the cpu at runtime to avoid a #ifdef ?



>  #ifndef mc146818_decode_year
>  #define mc146818_decode_year(year) ((year) < 70 ? (year) + 2000 : (year) + 
> 1970)