linux-mips
[Top] [All Lists]

Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.

To: linux-mips@linux-mips.org
Subject: Re: [PATCH V5 01/18] MIPS: Loongson: Add basic Loongson-3 definition.
From: John Crispin <john@phrozen.org>
Date: Sun, 12 Aug 2012 07:51:35 +0200
In-reply-to: <1344677543-22591-2-git-send-email-chenhc@lemote.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1344677543-22591-1-git-send-email-chenhc@lemote.com> <1344677543-22591-2-git-send-email-chenhc@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16
On 11/08/12 11:32, Huacai Chen wrote:
>  #define PRID_IMP_LOONGSON2   0x6300
> +#define PRID_IMP_LOONGSON3   0x6300
>  

as PRID_IMP_LOONGSON2 and PRID_IMP_LOONGSON3 share the same value, its
not really a uniq ID anymore. Maybe change this to a common PRID ?

patch 2/18 does not even make use of this new symbol inside
arch/mips/kernel/cpu-probe.c

John

<Prev in Thread] Current Thread [Next in Thread>