linux-mips
[Top] [All Lists]

Re: [PATCH] usb: host: mips: sead3: Update for EHCI register structure.

To: "Steven J. Hill" <sjhill@mips.com>
Subject: Re: [PATCH] usb: host: mips: sead3: Update for EHCI register structure.
From: Alan Stern <stern@rowland.harvard.edu>
Date: Tue, 7 Aug 2012 13:21:13 -0400 (EDT)
Cc: linux-usb@vger.kernel.org, <linux-mips@linux-mips.org>
In-reply-to: <1344292171-3111-1-git-send-email-sjhill@mips.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Sender: linux-mips-bounce@linux-mips.org
On Mon, 6 Aug 2012, Steven J. Hill wrote:

> From: "Steven J. Hill" <sjhill@mips.com>
> 
> One line fix after 'struct ehci_regs' definition was changed
> in commit a46af4ebf9ffec35eea0390e89935197b833dc61.
> 
> Signed-off-by: Steven J. Hill <sjhill@mips.com>
> ---
>  drivers/usb/host/ehci-sead3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
> index 58c96bd..0c9e43c 100644
> --- a/drivers/usb/host/ehci-sead3.c
> +++ b/drivers/usb/host/ehci-sead3.c
> @@ -40,7 +40,7 @@ static int ehci_sead3_setup(struct usb_hcd *hcd)
>       ehci->need_io_watchdog = 0;
>  
>       /* Set burst length to 16 words. */
> -     ehci_writel(ehci, 0x1010, &ehci->regs->reserved[1]);
> +     ehci_writel(ehci, 0x1010, &ehci->regs->reserved1[1]);
>  
>       return ret;
>  }

Acked-by: Alan Stern <stern@rowland.harvard.edu>

I never thought to check if any of the platform drivers were actually 
using these reserved memory addresses.

Alan Stern


<Prev in Thread] Current Thread [Next in Thread>