linux-mips
[Top] [All Lists]

Re: [PATCH v2 0/4] netdev/phy: 10G PHY support.

To: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 0/4] netdev/phy: 10G PHY support.
From: David Daney <ddaney.cavm@gmail.com>
Date: Thu, 28 Jun 2012 10:05:52 -0700
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, afleming@gmail.com, david.daney@cavium.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=7tb9SrXXk7tubgI0bALvNmzpTdtTQrLavIz0rieCQCA=; b=YwYX7WnfnVQv/iPtgjzZ/lE9SjjPYfzPfqM0TlY/PbYC1iNowATSZMQaNf7XlOjvui vtnvu/fYI0tr40VZ325bgnmFHcyrefMPbj0jKX5He//JAU/tyhjcs5j3zk0qynZ1g8tm 2IMRRE3ntwUdK8JIrRO4xGYXBtYWKWKmySPeYQG8Af2ipljq35Z98EV3slfrYDY99anL gLfxr5KtcFPJUdXFvSpMaU9cTYiafnsBao+ukUuhXEbmCTKaiRy+svYUQYWgDo/vmNWt L81rzcxEV2liZpKc5ELD/b1PJbqr+C2EwQe4aK8l5uO2C2EZDf/0FbfmUMvz7H92aYTu SXlw==
In-reply-to: <20120627.212941.485325944406335522.davem@davemloft.net>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1340818418-10382-1-git-send-email-ddaney.cavm@gmail.com> <20120627.212941.485325944406335522.davem@davemloft.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 06/27/2012 09:29 PM, David Miller wrote:
From: David Daney<ddaney.cavm@gmail.com>
Date: Wed, 27 Jun 2012 10:33:34 -0700

From: David Daney<david.daney@cavium.com>

The only non-cosmetic change from v1 is to pass an additional argument
to get_phy_device() that indicates that the PHY uses 802.3 clause 45
signaling, previously I had been using a high order bit of the addr
parameter for this.

There are also changes from v1 in the code and comment formatting.
These should now be closer to what David Miller prefers.

Applied, but I had to add the following warning fixup:

Thank You.


--------------------
phy: Fix warning in get_phy_device().

drivers/net/phy/phy_device.c: In function ʽget_phy_deviceʼ:
drivers/net/phy/phy_device.c:340:14: warning: ʽphy_idʼ may be used 
uninitialized in this function [-Wmaybe-uninitialized]

GCC can't see that when we return zero we always initialize
phy_id and that's the only path where we use it.

Initialize phy_id to zero to shut it up.


FWIW: I was testing with GCC-4.6.3 and saw no such warnings.

David Daney


Signed-off-by: David S. Miller<davem@davemloft.net>
---
  drivers/net/phy/phy_device.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index ef4cdee..47e02e7 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -327,9 +327,9 @@ static int get_phy_id(struct mii_bus *bus, int addr, u32 
*phy_id,
   */
  struct phy_device *get_phy_device(struct mii_bus *bus, int addr, bool is_c45)
  {
-       struct phy_device *dev = NULL;
-       u32 phy_id;
        struct phy_c45_device_ids c45_ids = {0};
+       struct phy_device *dev = NULL;
+       u32 phy_id = 0;
        int r;

        r = get_phy_id(bus, addr,&phy_id, is_c45,&c45_ids);


<Prev in Thread] Current Thread [Next in Thread>