linux-mips
[Top] [All Lists]

Re: [PATCH 2/7] MIPS: BCM63XX: Move DMA descriptor definition into commo

To: Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 2/7] MIPS: BCM63XX: Move DMA descriptor definition into common header file
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Tue, 26 Jun 2012 17:13:44 +0200
Cc: ralf@linux-mips.org, ffainelli@freebox.fr, mbizon@freebox.fr, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=/+VpWVTx9Iqrw12sjqLvAyYrM6tTXYM/EA2RtAXd1vI=; b=FMCrjj5LZ8WGir3Y9cXIoROpsJpEAW1hKfBZpnYA4U35VwxKbl7hV6oWEKQkR7BSDF 5PpBNYOCw+R7IgdOB6EuWWanga1M1AKfJbXxQeRzt2Ki5yuxqV/vDlVzdI6ucKX5cfOJ ZjJXNgpvIoL5cp1ZvMM6wA/9J8P4viwpzlTES2p2QuXvd4rByFraGLq4/zM05tm8Vitk GdUbYl3U17Qwk00O2NQC2fSKWv0xbkat2+9i+Izwso2WGGcsVmfQf7jOAKXHBIW5qqUX d9+BWwphzI6VFqjNbe0zOeqTUcQPjoYtphlnhLBDlCZkHHeuF7IT1DJBk2e+oKXM0225 Ixtw==
In-reply-to: <3c614d8672835e3950bddd7adbcecf05@localhost>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <0f67eabbb0d5c59add27e42a08b94944@localhost> <3c614d8672835e3950bddd7adbcecf05@localhost>
Sender: linux-mips-bounce@linux-mips.org
Hi Kevin,

On 23 June 2012 07:14, Kevin Cernekee <cernekee@gmail.com> wrote:
> The "IUDMA" engine used by bcm63xx_enet is also used by other blocks,
> such as the USB 2.0 device.  Move the definitions into a common file so
> that they do not need to be duplicated in each driver.

If it's common, maybe then it shouldn't be in bcm63xx_dev_enet.h but
something like bcm63xx_iudma.h, and the struct also renamed to
something generic (iudma_desc or so).

Regards,
Jonas

<Prev in Thread] Current Thread [Next in Thread>