linux-mips
[Top] [All Lists]

Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support.

To: Huacai Chen <chenhuacai@gmail.com>
Subject: Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support.
From: Yong Zhang <yong.zhang@windriver.com>
Date: Wed, 20 Jun 2012 14:36:42 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Huacai Chen <chenhc@lemote.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>, David Daney <ddaney@caviumnetworks.com>
In-reply-to: <CAAhV-H5cErPcKYV1Onc-b5S4qRunKbwZOACe2B8NLF0af6TrZQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1340088624-25550-1-git-send-email-chenhc@lemote.com> <1340088624-25550-16-git-send-email-chenhc@lemote.com> <20120619093113.GB305@windriver.com> <CAAhV-H5cErPcKYV1Onc-b5S4qRunKbwZOACe2B8NLF0af6TrZQ@mail.gmail.com>
Reply-to: Yong Zhang <yong.zhang@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 19, 2012 at 06:51:07PM +0800, Huacai Chen wrote:
> On Tue, Jun 19, 2012 at 5:31 PM, Yong Zhang <yong.zhang@windriver.com> wrote:
> > On Tue, Jun 19, 2012 at 02:50:23PM +0800, Huacai Chen wrote:
> >> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
> >> index e9a5fd7..69b17a9 100644
> >> --- a/arch/mips/kernel/process.c
> >> +++ b/arch/mips/kernel/process.c
> >> @@ -72,9 +72,7 @@ void __noreturn cpu_idle(void)
> >> ? ? ? ? ? ? ? ? ? ? ? }
> >> ? ? ? ? ? ? ? }
> >> ?#ifdef CONFIG_HOTPLUG_CPU
> >> - ? ? ? ? ? ? if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map) &&
> >> - ? ? ? ? ? ? ? ? (system_state == SYSTEM_RUNNING ||
> >> - ? ? ? ? ? ? ? ? ?system_state == SYSTEM_BOOTING))
> >> + ? ? ? ? ? ? if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map))
> >> ? ? ? ? ? ? ? ? ? ? ? play_dead();
> >
> > I think patch like this should be separated from BSP code.
> >
> > BTW, what's the story behind this change?
> When poweroff, disable_nonboot_cpus() is called, and if HOTPLUG_CPU is
> configured, disable_nonboot_cpus() is not an empty function but try to
> offline nonboot cores. If without this change, poweroff fails.

Yeah. It's an issue. I think Cavium is also affected (Cc'ing David).

So mind making this a single patch? We should also send it to -stable IMHO.

Thanks,
Yong

<Prev in Thread] Current Thread [Next in Thread>