linux-mips
[Top] [All Lists]

Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support.

To: Yong Zhang <yong.zhang@windriver.com>
Subject: Re: [PATCH V2 15/16] MIPS: Loongson 3: Add CPU Hotplug support.
From: Huacai Chen <chenhuacai@gmail.com>
Date: Tue, 19 Jun 2012 18:51:07 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Huacai Chen <chenhc@lemote.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=ZpC7sTvnzu8pgkF8RWX4ul3erXw8uXLvj8xgFDVbzo4=; b=xQtsamDcyxusERHIrIHoVwlXO5lwAmX/0qk6pWxSUQneqZdrBcz/NGMph5JaCnHowg vJG5VbMIIyLJCHIv8WQ5eyREAxn8vWrcvd23Ark2DnvTgTEb94ByJkB12T7xI339IgXq cWnyzKzdp9LDoLNITK0Go0OsnWZ68UfDCiIIfJAX9tm+12PcSyoucd0zzWhOjQFuQcA0 AKbBw2qTXj7NRiB0caVPDk2Sweo4g5OYtAx8t2bhTBl8s+eKrWoccN+dzk/vUDmd4F+V xvxB2hksHfce/DaJFU9vx5MtNdAYBnUJwZbnxEGPLFcy6rG0mBIiOz2JEtlsmDfJ8m7a 6xYA==
In-reply-to: <20120619093113.GB305@windriver.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1340088624-25550-1-git-send-email-chenhc@lemote.com> <1340088624-25550-16-git-send-email-chenhc@lemote.com> <20120619093113.GB305@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Jun 19, 2012 at 5:31 PM, Yong Zhang <yong.zhang@windriver.com> wrote:
> On Tue, Jun 19, 2012 at 02:50:23PM +0800, Huacai Chen wrote:
>> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
>> index e9a5fd7..69b17a9 100644
>> --- a/arch/mips/kernel/process.c
>> +++ b/arch/mips/kernel/process.c
>> @@ -72,9 +72,7 @@ void __noreturn cpu_idle(void)
>>                       }
>>               }
>>  #ifdef CONFIG_HOTPLUG_CPU
>> -             if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map) &&
>> -                 (system_state == SYSTEM_RUNNING ||
>> -                  system_state == SYSTEM_BOOTING))
>> +             if (!cpu_online(cpu) && !cpu_isset(cpu, cpu_callin_map))
>>                       play_dead();
>
> I think patch like this should be separated from BSP code.
>
> BTW, what's the story behind this change?
When poweroff, disable_nonboot_cpus() is called, and if HOTPLUG_CPU is
configured, disable_nonboot_cpus() is not an empty function but try to
offline nonboot cores. If without this change, poweroff fails.

>
> Thanks,
> Yong

<Prev in Thread] Current Thread [Next in Thread>