linux-mips
[Top] [All Lists]

Re: [alsa-devel] [PATCH V2 13/16] ALSA: HDA: Make hda sound card usable

To: Huacai Chen <chenhuacai@gmail.com>
Subject: Re: [alsa-devel] [PATCH V2 13/16] ALSA: HDA: Make hda sound card usable for Loongson.
From: Clemens Ladisch <clemens@ladisch.de>
Date: Tue, 19 Jun 2012 11:09:41 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Zhangjin Wu <wuzhangjin@gmail.com>, Hua Yan <yanh@lemote.com>, Fuxin Zhang <zhangfx@lemote.com>, Hongliang Tao <taohl@lemote.com>, Huacai Chen <chenhc@lemote.com>
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpout; bh=7D6TUZIjk6VFaBgB2uCyqi W6zsY=; b=R+kcbaEuT81rTReyWFaucy10Zh1bQOHpdtOYcHDV7WHPcM0IDkoD3+ YclgzToxBIS21phOKN9K0/pvKjiKyM0Zocofod2SKGbTwT01dvNcY2fTUY0C3AKj wO8TXX8byKlri3FllN6ZIAYiffHAyVuno5KesxVjdd0CjrstladEw=
In-reply-to: <1340088624-25550-14-git-send-email-chenhc@lemote.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1340088624-25550-1-git-send-email-chenhc@lemote.com> <1340088624-25550-14-git-send-email-chenhc@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
Huacai Chen wrote:
> 1, Use 32-bit DMA as a workaround (Loongson has a hardware bug that it
>    doesn't support DMA address above 4GB).
> 2, Modify patch_conexant.c to add Lemote specific code.

Please create separate patches for these two changes.

> +++ b/include/linux/pci_ids.h
> @@ -2906,3 +2906,5 @@
>  #define PCI_DEVICE_ID_XEN_PLATFORM   0x0001
>
>  #define PCI_VENDOR_ID_OCZ            0x1b85
> +
> +#define PCI_VENDOR_ID_LEMOTE         0x1c06

AFAICS this symbol is not used in this patch.

> +#ifdef CONFIG_CPU_LOONGSON3
> +     /* Workaround: Loongson 3 doesn't support 64-bit DMA */
> +     gcap &= ~ICH6_GCAP_64OK;
> +#endif

        /* Workaround: Loongson 3 doesn't actually support 64-bit DMA */


Regards,
Clemens

<Prev in Thread] Current Thread [Next in Thread>