linux-mips
[Top] [All Lists]

Re: [PATCH 09/14] ata: Use 32bit DMA in AHCI for Loongson 3.

To: huacai chen <chenhuacai@gmail.com>
Subject: Re: [PATCH 09/14] ata: Use 32bit DMA in AHCI for Loongson 3.
From: Borislav Petkov <bp@alien8.de>
Date: Sun, 17 Jun 2012 14:05:57 +0200
Cc: Sergei Shtylyov <sshtylyov@mvista.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Huacai Chen <chenhc@lemote.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>, linux-ide@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1339934759; bh=cPRh51WkOXfK8w8vbtEfaBqwXDhEQTpmyo06Z4uRfTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=Wa9+CJynFpBM CRUKrlFhbdao+oLAkeHBkVMy6sCf5pn9G4qY2Iqh/VzgYMd8kNDyiGLK3OvXWqTOtw/ RNIJroFZU03ULtk6SqU5v/Lds39MmgNI6E+XOJ1ksVvwniE3sNAJEd1U8DL6asjlkiw +mF0si654T6GfAwiqjOFQR0I8=
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1339934759; bh=cPRh51WkOXfK8w8vbtEfaBqwXDhEQTpmyo06Z4uRfTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=Wa9+CJynFpBM CRUKrlFhbdao+oLAkeHBkVMy6sCf5pn9G4qY2Iqh/VzgYMd8kNDyiGLK3OvXWqTOtw/ RNIJroFZU03ULtk6SqU5v/Lds39MmgNI6E+XOJ1ksVvwniE3sNAJEd1U8DL6asjlkiw +mF0si654T6GfAwiqjOFQR0I8=
In-reply-to: <CAAhV-H6AKp+aGUozOxQoLgGYQ+GtHMbKKC4MVkFA570zodjgDA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1339747801-28691-1-git-send-email-chenhc@lemote.com> <1339747801-28691-10-git-send-email-chenhc@lemote.com> <4FDB08AC.8010208@mvista.com> <CAAhV-H6AKp+aGUozOxQoLgGYQ+GtHMbKKC4MVkFA570zodjgDA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jun 15, 2012 at 08:42:47PM +0800, huacai chen wrote:
> On Fri, Jun 15, 2012 at 6:04 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> > Hello.
> >
> >
> > On 15-06-2012 12:09, Huacai Chen wrote:
> >
> >> Signed-off-by: Huacai Chen<chenhc@lemote.com>
> >> Signed-off-by: Hongliang Tao<taohl@lemote.com>
> >> Signed-off-by: Hua Yan<yanh@lemote.com>
> >
> >
> >   You  should have CCed the 'linux-ide' mailing list.
> >
> >
> >> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> >> index ebaf67e..3e3cfd8 100644
> >> --- a/drivers/ata/ahci.c
> >> +++ b/drivers/ata/ahci.c
> >> @@ -183,7 +183,12 @@ static const struct ata_port_info ahci_port_info[] =
> >> {
> >>        },
> >>        [board_ahci_sb700] =    /* for SB700 and SB800 */
> >>        {
> >> +#ifndef CONFIG_CPU_LOONGSON3
> >>                AHCI_HFLAGS     (AHCI_HFLAG_IGN_SERR_INTERNAL),
> >> +#else
> >> +               AHCI_HFLAGS     (AHCI_HFLAG_IGN_SERR_INTERNAL |
> >> +                                               AHCI_HFLAG_32BIT_ONLY),
> >> +#endif
> >
> >
> >   No, this #ifdef'ery won't do. You should add a new board type.
> All Loongson-3 based machines use AMD SB700 chipsets, add a new board
> type is better than #ifdef?

SB700/800 chipsets don't need to set a 32-bit only DMA flag; why do you
need it when you use the same chipset?

-- 
Regards/Gruss,
    Boris.

<Prev in Thread] Current Thread [Next in Thread>