linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access

To: Jonas Gorski <jonas.gorski@gmail.com>, linux-mips@linux-mips.org, loongson-dev@googlegroups.com
Subject: Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Sun, 17 Jun 2012 11:09:43 +0200
In-reply-to: <20120616125847.GR2039@vicerveza.homeunix.net>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <20120615234641.6938B58FE7C@mail.viric.name> <CAOiHx==JS9KfPWxx+pyRNwvq-pWdhbZk+Q-qvRPsVGh90Xso9Q@mail.gmail.com> <20120616121513.GP2039@vicerveza.homeunix.net> <20120616125847.GR2039@vicerveza.homeunix.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Jun 16, 2012 at 02:58:47PM +0200, Lluís Batlle i Rossell wrote:
> Hello again,
> 
> On Sat, Jun 16, 2012 at 02:15:13PM +0200, Lluís Batlle i Rossell wrote:
> > > From what I can tell, ldc1 is a valid MIPS32 instruction, so this
> > > should probably be something like
> > > 
> > >         case ld_op:
> > > #ifndef CONFIG_64BIT
> > >                 return sigill;
> > > #endif
> > 
> > I agree! I'll repost with these fixes.
> 
> Well, I think I take my words back. Handling the ldc1/sdc1 cases in MIPS32 is
> tricker than I thought first, because I can't use ldl/ldr or sdl/sdr there.
> Given my ability with mips assembly, I leave the patch as is.
> 
> In 'patchwork' I had set the patch first to superseeded, but then I set it 
> back
> to New.

why is there a reason for this ? Unaligned FPU access shouts to me simply
broken code, go fix that. But maybe I'm wrong ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

<Prev in Thread] Current Thread [Next in Thread>