linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access
From: Lluís Batlle i Rossell <viric@viric.name>
Date: Sat, 16 Jun 2012 14:15:13 +0200
Cc: linux-mips@linux-mips.org, loongson-dev@googlegroups.com
In-reply-to: <CAOiHx==JS9KfPWxx+pyRNwvq-pWdhbZk+Q-qvRPsVGh90Xso9Q@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Mail-followup-to: Jonas Gorski <jonas.gorski@gmail.com>, linux-mips@linux-mips.org, loongson-dev@googlegroups.com
References: <20120615234641.6938B58FE7C@mail.viric.name> <CAOiHx==JS9KfPWxx+pyRNwvq-pWdhbZk+Q-qvRPsVGh90Xso9Q@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.20 (2009-06-14)
Hello,

thank you for the review.

On Sat, Jun 16, 2012 at 01:21:27PM +0200, Jonas Gorski wrote:
> On 16 June 2012 00:22, Lluis Batlle i Rossell <viric@viric.name> wrote:
> > Reusing most of the code from lw,ld,sw,sd emulation,
> > I add the emulation for lwc1,ldc1,swc1,sdc1.
> 
> What about lwxc1, ldxc1, swxc1 and sdxc1? These also require alignment.

Looking at gcc code, I could not find those instructions emmitted. I could write
some assembly tests cases though.

> >        case ld_op:
> > +       case ldc1_op:
> >  #ifdef CONFIG_64BIT
> 
> From what I can tell, ldc1 is a valid MIPS32 instruction, so this
> should probably be something like
> 
>         case ld_op:
> #ifndef CONFIG_64BIT
>                 return sigill;
> #endif

I agree! I'll repost with these fixes.

Regards,
Lluís

<Prev in Thread] Current Thread [Next in Thread>