Re: [PATCH] MIPS: Add emulation for fpureg-mem unaligned access

[Lluís Batlle i Rossell <viric@viric.name>]

Hello,

thank you for the review.

On Sat, Jun 16, 2012 at 01:21:27PM +0200, Jonas Gorski wrote:
> On 16 June 2012 00:22, Lluis Batlle i Rossell <viric@viric.name> wrote:
> > Reusing most of the code from lw,ld,sw,sd emulation,
> > I add the emulation for lwc1,ldc1,swc1,sdc1.
> 
> What about lwxc1, ldxc1, swxc1 and sdxc1? These also require alignment.

Looking at gcc code, I could not find those instructions emmitted. I could write
some assembly tests cases though.

> >        case ld_op:
> > +       case ldc1_op:
> >  #ifdef CONFIG_64BIT
> 
> From what I can tell, ldc1 is a valid MIPS32 instruction, so this
> should probably be something like
> 
>         case ld_op:
> #ifndef CONFIG_64BIT
>                 return sigill;
> #endif

I agree! I'll repost with these fixes.

Regards,
Lluís