linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: remove three unused headers

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: remove three unused headers
From: Paul Bolle <pebolle@tiscali.nl>
Date: Wed, 13 Jun 2012 23:53:51 +0200
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <20120613145614.GC5516@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
References: <1339491792.30984.110.camel@x61.thuisdomein> <20120613145614.GC5516@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 2012-06-13 at 15:56 +0100, Ralf Baechle wrote:
> On Tue, Jun 12, 2012 at 11:03:12AM +0200, Paul Bolle wrote:
> 
> > No file includes these three headers. It seems they have never been
> > included since at least v2.6.12-rc2. They can safely be removed.
> 
> >  arch/mips/include/asm/sibyte/sb1250_l2c.h |  131 -------
> >  arch/mips/include/asm/sibyte/sb1250_ldt.h |  422 ----------------------
> >  arch/mips/include/asm/sibyte/sb1250_mc.h  |  550 
> > -----------------------------
> 
> These headers describe the on-chip hardware of the SB1250 SOC.  Some of
> the drivers to use them are currently stuck midflight on their path to
> submission.

OK, I see. Thanks.

>   The remaining ones I'd like to keep around as documentation
> or for later use.

I'd say that arch/mips/include/ is were one puts code and
Documentation/mips/ is were one puts documentation. Can't the unused
header files you want to keep (preferably with, say, a .txt extension)
be added to Documentation/mips/?
 
>   Ditto for your other BCM1480 related patch....

Thanks,


Paul Bolle


<Prev in Thread] Current Thread [Next in Thread>